2013-05-06 03:42:16

by Jingoo Han

Subject: [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/pinctrl/pinctrl-mxs.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
index b45c4eb..f5d5643 100644
--- a/drivers/pinctrl/pinctrl-mxs.c
+++ b/drivers/pinctrl/pinctrl-mxs.c
@@ -515,7 +515,6 @@ int mxs_pinctrl_probe(struct platform_device *pdev,
return 0;

err:
- platform_set_drvdata(pdev, NULL);
iounmap(d->base);
return ret;
}
@@ -525,7 +524,6 @@ int mxs_pinctrl_remove(struct platform_device *pdev)
{
struct mxs_pinctrl_data *d = platform_get_drvdata(pdev);

- platform_set_drvdata(pdev, NULL);
pinctrl_unregister(d->pctl);
iounmap(d->base);

--
1.7.2.5

2013-05-06 08:48:24

by Shawn Guo

Subject: Re: [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata()

On Mon, May 06, 2013 at 12:42:13PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> drivers/pinctrl/pinctrl-mxs.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
> index b45c4eb..f5d5643 100644
> --- a/drivers/pinctrl/pinctrl-mxs.c
> +++ b/drivers/pinctrl/pinctrl-mxs.c
> @@ -515,7 +515,6 @@ int mxs_pinctrl_probe(struct platform_device *pdev,
> return 0;
>
> err:
> - platform_set_drvdata(pdev, NULL);
> iounmap(d->base);
> return ret;
> }
> @@ -525,7 +524,6 @@ int mxs_pinctrl_remove(struct platform_device *pdev)
> {
> struct mxs_pinctrl_data *d = platform_get_drvdata(pdev);
>
> - platform_set_drvdata(pdev, NULL);
> pinctrl_unregister(d->pctl);
> iounmap(d->base);
>
> --
> 1.7.2.5
>
>

2013-05-14 11:57:04

by Linus Walleij

Subject: Re: [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata()

On Mon, May 6, 2013 at 5:42 AM, Jingoo Han <[email protected]> wrote:

> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <[email protected]>

Patch applied with Shawn's ACK.

Thanks!
Linus Walleij