2016-11-05 14:36:01

by Heinrich Schuchardt

Subject: [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression

for_each_property_of_node(pins, pp) checks that pp is not NULL.
So there is no need to check it inside the loop.

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
drivers/pinctrl/pinctrl-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 8308f15..676efcc 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1181,7 +1181,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
if (!strcmp(pp->name, "name"))
continue;

- if (pp && (pp->length/sizeof(__be32)) >= OF_GPIO_ARGS_MIN) {
+ if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) {
npins++;
} else {
pr_warn("Invalid st,pins in %s node\n", np->name);
--
2.10.1

2016-11-07 09:05:46

by Patrice CHOTARD

Subject: Re: [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression

On 11/05/2016 03:35 PM, Heinrich Schuchardt wrote:
> for_each_property_of_node(pins, pp) checks that pp is not NULL.
> So there is no need to check it inside the loop.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
> drivers/pinctrl/pinctrl-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 8308f15..676efcc 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1181,7 +1181,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> if (!strcmp(pp->name, "name"))
> continue;
>
> - if (pp && (pp->length/sizeof(__be32)) >= OF_GPIO_ARGS_MIN) {
> + if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) {
> npins++;
> } else {
> pr_warn("Invalid st,pins in %s node\n", np->name);
>

Hi Heinrich

Acked-by: Patrice Chotard <[email protected]>

Thanks

2016-11-08 10:27:48

by Linus Walleij

Subject: Re: [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression

On Sat, Nov 5, 2016 at 3:35 PM, Heinrich Schuchardt <[email protected]> wrote:

> for_each_property_of_node(pins, pp) checks that pp is not NULL.
> So there is no need to check it inside the loop.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>

Patch applied with Patrice's ACK.

Yours,
Linus Walleij