The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
for the dev_err() messages). The probe function should return an error
if one of the banks failed to initialize properly indicated by
not returning non-0.
Signed-off-by: Nicholas Mc Guire <[email protected]>
Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
---
V2: A logic error spoted by Sean Wang <[email protected]> the
success case is 0 and thus returning early should be on on
ret!=0 and not on !ret - thanks for catching this stupid mistake !
Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y,
GPIOLIB=y, GPIO_MT7621=y
Patch is against 4.20-rc3 (localversion-next is next-20181121)
drivers/gpio/gpio-mt7621.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
index 1ec95bc..68fca8b 100644
--- a/drivers/gpio/gpio-mt7621.c
+++ b/drivers/gpio/gpio-mt7621.c
@@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
struct device_node *np = dev->of_node;
struct mtk *mtk;
int i;
+ int ret;
mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL);
if (!mtk)
@@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mtk);
mediatek_gpio_irq_chip.name = dev_name(dev);
- for (i = 0; i < MTK_BANK_CNT; i++)
- mediatek_gpio_bank_probe(dev, np, i);
+ for (i = 0; i < MTK_BANK_CNT; i++) {
+ ret = mediatek_gpio_bank_probe(dev, np, i);
+ if (ret)
+ return ret;
+ }
return 0;
}
--
2.1.4
Nicholas Mc Guire <[email protected]> 於 2018年11月27日 週二 上午9:07寫道：
>
> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
> for the dev_err() messages). The probe function should return an error
> if one of the banks failed to initialize properly indicated by
> not returning non-0.
>
> Signed-off-by: Nicholas Mc Guire <[email protected]>
Acked-by: Sean Wang <[email protected]>
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
> ---
>
> V2: A logic error spoted by Sean Wang <[email protected]> the
> success case is 0 and thus returning early should be on on
> ret!=0 and not on !ret - thanks for catching this stupid mistake !
>
> Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y,
> GPIOLIB=y, GPIO_MT7621=y
>
> Patch is against 4.20-rc3 (localversion-next is next-20181121)
>
> drivers/gpio/gpio-mt7621.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
> index 1ec95bc..68fca8b 100644
> --- a/drivers/gpio/gpio-mt7621.c
> +++ b/drivers/gpio/gpio-mt7621.c
> @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
> struct device_node *np = dev->of_node;
> struct mtk *mtk;
> int i;
> + int ret;
>
> mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL);
> if (!mtk)
> @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, mtk);
> mediatek_gpio_irq_chip.name = dev_name(dev);
>
> - for (i = 0; i < MTK_BANK_CNT; i++)
> - mediatek_gpio_bank_probe(dev, np, i);
> + for (i = 0; i < MTK_BANK_CNT; i++) {
> + ret = mediatek_gpio_bank_probe(dev, np, i);
> + if (ret)
> + return ret;
> + }
>
> return 0;
> }
> --
> 2.1.4
>
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
On Tue, Nov 27, 2018 at 6:06 PM Nicholas Mc Guire <[email protected]> wrote:
> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
> for the dev_err() messages). The probe function should return an error
> if one of the banks failed to initialize properly indicated by
> not returning non-0.
>
> Signed-off-by: Nicholas Mc Guire <[email protected]>
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
Patch applied with Sean's ACK.
Yours,
Linus Walleij