2021-03-23 01:39:50

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] drivers: pinctrl: Remove duplicate include of io.h

linux/io.h has been included at line 6, so remove the
duplicate include at line 18.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/pinctrl/pinctrl-k210.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
index 8a733cf77ba0..f831526d06ff 100644
--- a/drivers/pinctrl/pinctrl-k210.c
+++ b/drivers/pinctrl/pinctrl-k210.c
@@ -15,7 +15,6 @@
#include <linux/pinctrl/pinmux.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinconf-generic.h>
-#include <linux/io.h>

#include <dt-bindings/pinctrl/k210-fpioa.h>

--
2.25.1


2021-03-23 01:54:04

by Damien Le Moal

[permalink] [raw]
Subject: Re: [PATCH] drivers: pinctrl: Remove duplicate include of io.h

On 2021/03/23 10:38, Wan Jiabing wrote:
> linux/io.h has been included at line 6, so remove the
> duplicate include at line 18.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/pinctrl/pinctrl-k210.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index 8a733cf77ba0..f831526d06ff 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -15,7 +15,6 @@
> #include <linux/pinctrl/pinmux.h>
> #include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinconf-generic.h>
> -#include <linux/io.h>
>
> #include <dt-bindings/pinctrl/k210-fpioa.h>
>
>

Good catch !

Reviewed-by: Damien Le Moal <[email protected]>


--
Damien Le Moal
Western Digital Research

2021-03-25 09:31:46

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] drivers: pinctrl: Remove duplicate include of io.h

On Tue, Mar 23, 2021 at 2:37 AM Wan Jiabing <[email protected]> wrote:

> linux/io.h has been included at line 6, so remove the
> duplicate include at line 18.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Patch applied!

Yours,
Linus Walleij