2023-12-18 16:47:12

by Ovidiu Panait

Subject: [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize

From: Ovidiu Panait <[email protected]>

The value of reqsize must only be changed through the helper.

Signed-off-by: Ovidiu Panait <[email protected]>
---
Cc: Heiko Stuebner <[email protected]>
Cc: Corentin Labbe <[email protected]>
Cc: [email protected]
Cc: [email protected]

drivers/crypto/rockchip/rk3288_crypto_skcipher.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
index da95747d973f..9393e10671c2 100644
--- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
+++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
@@ -445,8 +445,8 @@ static int rk_cipher_tfm_init(struct crypto_skcipher *tfm)
return PTR_ERR(ctx->fallback_tfm);
}

- tfm->reqsize = sizeof(struct rk_cipher_rctx) +
- crypto_skcipher_reqsize(ctx->fallback_tfm);
+ crypto_skcipher_set_reqsize(tfm, sizeof(struct rk_cipher_rctx) +
+ crypto_skcipher_reqsize(ctx->fallback_tfm));

return 0;
}
--
2.34.1

2023-12-18 16:47:26

by Ovidiu Panait

Subject: [PATCH 5/7] crypto: sl3516 - Use helper to set reqsize

From: Ovidiu Panait <[email protected]>

The value of reqsize must only be changed through the helper.

Signed-off-by: Ovidiu Panait <[email protected]>
---
Cc: Hans Ulli Kroll <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Corentin Labbe <[email protected]>
Cc: [email protected]

drivers/crypto/gemini/sl3516-ce-cipher.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c
index 49dce9e0a834..583010b2d007 100644
--- a/drivers/crypto/gemini/sl3516-ce-cipher.c
+++ b/drivers/crypto/gemini/sl3516-ce-cipher.c
@@ -332,8 +332,8 @@ int sl3516_ce_cipher_init(struct crypto_tfm *tfm)
return PTR_ERR(op->fallback_tfm);
}

- sktfm->reqsize = sizeof(struct sl3516_ce_cipher_req_ctx) +
- crypto_skcipher_reqsize(op->fallback_tfm);
+ crypto_skcipher_set_reqsize(sktfm, sizeof(struct sl3516_ce_cipher_req_ctx) +
+ crypto_skcipher_reqsize(op->fallback_tfm));

dev_info(op->ce->dev, "Fallback for %s is %s\n",
crypto_tfm_alg_driver_name(&sktfm->base),
--
2.34.1

2023-12-18 23:44:29

by Linus Walleij

Subject: Re: [PATCH 5/7] crypto: sl3516 - Use helper to set reqsize

On Mon, Dec 18, 2023 at 5:46 PM <[email protected]> wrote:

> From: Ovidiu Panait <[email protected]>
>
> The value of reqsize must only be changed through the helper.
>
> Signed-off-by: Ovidiu Panait <[email protected]>

Looks right to me:
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij