2012-10-15 00:48:57

by Thiago Farina

Subject: [PATCH] power: remove duplicated include of abx500.h from ab8500_fb.c

Signed-off-by: Thiago Farina <[email protected]>
---
drivers/power/ab8500_fg.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
index 2db8cc2..1041397 100644
--- a/drivers/power/ab8500_fg.c
+++ b/drivers/power/ab8500_fg.c
@@ -15,22 +15,21 @@
* Arun R Murthy <[email protected]>
*/

-#include <linux/init.h>
-#include <linux/module.h>
+#include <linux/completion.h>
+#include <linux/delay.h>
#include <linux/device.h>
+#include <linux/init.h>
#include <linux/interrupt.h>
-#include <linux/platform_device.h>
-#include <linux/power_supply.h>
#include <linux/kobject.h>
-#include <linux/mfd/abx500/ab8500.h>
#include <linux/mfd/abx500.h>
-#include <linux/slab.h>
#include <linux/mfd/abx500/ab8500-bm.h>
-#include <linux/delay.h>
#include <linux/mfd/abx500/ab8500-gpadc.h>
-#include <linux/mfd/abx500.h>
+#include <linux/mfd/abx500/ab8500.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/power_supply.h>
+#include <linux/slab.h>
#include <linux/time.h>
-#include <linux/completion.h>

#define MILLI_TO_MICRO 1000
#define FG_LSB_IN_MA 1627
--
1.8.0.rc2

2012-10-15 12:37:26

by Linus Walleij

Subject: Re: [PATCH] power: remove duplicated include of abx500.h from ab8500_fb.c

On Mon, Oct 15, 2012 at 2:48 AM, Thiago Farina <[email protected]> wrote:

> Signed-off-by: Thiago Farina <[email protected]>

The subject of this patch and the empty commit blurb does not
describe what you're actually doing: you are also re-arranging all
the #include directives in alphabetic order, so please tell that
in the commit message.

Yours,
Linus Walleij