2015-11-22 16:39:11

by William Breathitt Gray

Subject: [PATCH] gpio: 104-idio-16: Disable IRQ on device probe

IRQ should be disabled on device probe so that the device IRQ is in a
known starting state. If IRQ is not disabled, interrupts may be reported
as handled by the IRQ handler, despite no irq_unmask calls made by the
user.

Signed-off-by: William Breathitt Gray <[email protected]>
---
drivers/gpio/gpio-104-idio-16.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c
index 81b6904..efe3ff7 100644
--- a/drivers/gpio/gpio-104-idio-16.c
+++ b/drivers/gpio/gpio-104-idio-16.c
@@ -242,6 +242,9 @@ static int __init idio_16_probe(struct platform_device *pdev)
goto err_gpio_register;
}

+ /* Disable IRQ by default */
+ outb(0, base + 2);
+
err = gpiochip_irqchip_add(&idio16gpio->chip, &idio_16_irqchip, 0,
handle_edge_irq, IRQ_TYPE_NONE);
if (err) {
--
2.4.10

2015-11-30 13:42:32

by Linus Walleij

Subject: Re: [PATCH] gpio: 104-idio-16: Disable IRQ on device probe

On Sun, Nov 22, 2015 at 5:38 PM, William Breathitt Gray
<[email protected]> wrote:

> IRQ should be disabled on device probe so that the device IRQ is in a
> known starting state. If IRQ is not disabled, interrupts may be reported
> as handled by the IRQ handler, despite no irq_unmask calls made by the
> user.
>
> Signed-off-by: William Breathitt Gray <[email protected]>

Patch applied.

Yours,
Linus Walleij