2024-04-01 17:30:22

by Christophe JAILLET

Subject: [PATCH] pinctrl: max77620: Remove an unused fields in struct max77620_pin_info and max77620_pctrl_info

In "struct max77620_pin_info", the 'pull_config' field is unused.
In "struct max77620_pctrl_info", the 'pins_current_opt' field is unused.

Remove them.

On my x86_64 config, with allmodconfig, this shrinks the struct
max77620_pctrl_info from 360 bytes to 296.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.
---
drivers/pinctrl/pinctrl-max77620.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-max77620.c b/drivers/pinctrl/pinctrl-max77620.c
index ab723ab4ec1d..d236daa7c13e 100644
--- a/drivers/pinctrl/pinctrl-max77620.c
+++ b/drivers/pinctrl/pinctrl-max77620.c
@@ -88,7 +88,6 @@ struct max77620_pingroup {

struct max77620_pin_info {
enum max77620_pin_ppdrv drv_type;
- int pull_config;
};

struct max77620_fps_config {
@@ -104,7 +103,6 @@ struct max77620_pctrl_info {
struct device *dev;
struct pinctrl_dev *pctl;
struct regmap *rmap;
- int pins_current_opt[MAX77620_GPIO_NR];
const struct max77620_pin_function *functions;
unsigned int num_functions;
const struct max77620_pingroup *pin_groups;
--
2.44.0

2024-04-04 11:46:18

by Linus Walleij

Subject: Re: [PATCH] pinctrl: max77620: Remove an unused fields in struct max77620_pin_info and max77620_pctrl_info

On Mon, Apr 1, 2024 at 7:30 PM Christophe JAILLET
<[email protected]> wrote:

> In "struct max77620_pin_info", the 'pull_config' field is unused.
> In "struct max77620_pctrl_info", the 'pins_current_opt' field is unused.
>
> Remove them.
>
> On my x86_64 config, with allmodconfig, this shrinks the struct
> max77620_pctrl_info from 360 bytes to 296.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Patch applied.

Yours,
Linus Walleij