2022-09-28 09:53:27

by Chunyan Zhang

Subject: [PATCH 3/3] dt-bindings: gpio: Add compatible string for Unisoc UMS512

From: Chunyan Zhang <[email protected]>

UMS512 use the same GPIO and EIC controller with SC9860, so this
patch adds compatible string for UMS512 directly.

Signed-off-by: Chunyan Zhang <[email protected]>
---
.../bindings/gpio/sprd,gpio-eic.yaml | 33 +++++++++++++++----
.../devicetree/bindings/gpio/sprd,gpio.yaml | 7 +++-
2 files changed, 33 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
index e25ee1884c07..07f7d2b56da6 100644
--- a/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
+++ b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
@@ -42,12 +42,33 @@ description:

properties:
compatible:
- enum:
- - sprd,sc9860-eic-debounce
- - sprd,sc9860-eic-latch
- - sprd,sc9860-eic-async
- - sprd,sc9860-eic-sync
- - sprd,sc2731-eic
+ oneOf:
+ - enum:
+ - sprd,sc9860-eic-debounce
+ - sprd,sc9860-eic-latch
+ - sprd,sc9860-eic-async
+ - sprd,sc9860-eic-sync
+ - sprd,sc2731-eic
+ - items:
+ - enum:
+ - sprd,ums512-eic-debounce
+ - const: sprd,sc9860-eic-debounce
+ - items:
+ - enum:
+ - sprd,ums512-eic-latch
+ - const: sprd,sc9860-eic-latch
+ - items:
+ - enum:
+ - sprd,ums512-eic-async
+ - const: sprd,sc9860-eic-async
+ - items:
+ - enum:
+ - sprd,ums512-eic-sync
+ - const: sprd,sc9860-eic-sync
+ - items:
+ - enum:
+ - sprd,sc2730-eic
+ - const: sprd,sc2731-eic

reg:
minItems: 1
diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
index c0cd1ed9809b..a1ecb2b96a76 100644
--- a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
@@ -19,7 +19,12 @@ description:

properties:
compatible:
- const: sprd,sc9860-gpio
+ oneOf:
+ - const: sprd,sc9860-gpio
+ - items:
+ - enum:
+ - sprd,ums512-gpio
+ - const: sprd,sc9860-gpio

reg:
maxItems: 1
--
2.25.1

2022-09-28 12:04:08

by Krzysztof Kozlowski

Subject: Re: [PATCH 3/3] dt-bindings: gpio: Add compatible string for Unisoc UMS512

On 28/09/2022 11:29, Chunyan Zhang wrote:
> From: Chunyan Zhang <[email protected]>
>
> UMS512 use the same GPIO and EIC controller with SC9860, so this
> patch adds compatible string for UMS512 directly.

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

With commit msg fixed:

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-10-04 08:10:21

by Linus Walleij

Subject: Re: [PATCH 3/3] dt-bindings: gpio: Add compatible string for Unisoc UMS512

On Wed, Sep 28, 2022 at 11:29 AM Chunyan Zhang <[email protected]> wrote:

> From: Chunyan Zhang <[email protected]>
>
> UMS512 use the same GPIO and EIC controller with SC9860, so this
> patch adds compatible string for UMS512 directly.
>
> Signed-off-by: Chunyan Zhang <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij