2012-11-23 12:25:05

by Tushar Behera

Subject: [PATCH] mfd: ab8500-core: Fix invalid free of devm_ allocated data

The objects allocated by devm_* APIs are managed by devres and are
freed when the device is detached. Hence there is no need to remove
them explicitly in remove function.

Signed-off-by: Tushar Behera <[email protected]>
---
drivers/mfd/ab8500-core.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index 148d2ee..af7a6ba 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -1428,11 +1428,6 @@ static int __devexit ab8500_remove(struct platform_device *pdev)
sysfs_remove_group(&ab8500->dev->kobj, &ab8500_attr_group);

mfd_remove_devices(ab8500->dev);
- free_irq(ab8500->irq, ab8500);
-
- kfree(ab8500->oldmask);
- kfree(ab8500->mask);
- kfree(ab8500);

return 0;
}
--
1.7.4.1

2012-11-28 15:48:17

by Linus Walleij

Subject: Re: [PATCH] mfd: ab8500-core: Fix invalid free of devm_ allocated data

On Fri, Nov 23, 2012 at 1:18 PM, Tushar Behera <[email protected]> wrote:

> The objects allocated by devm_* APIs are managed by devres and are
> freed when the device is detached. Hence there is no need to remove
> them explicitly in remove function.
>
> Signed-off-by: Tushar Behera <[email protected]>

Looks good to me.
Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2012-11-30 10:52:19

by Samuel Ortiz

Subject: Re: [PATCH] mfd: ab8500-core: Fix invalid free of devm_ allocated data

Hi Tushar,

On Fri, Nov 23, 2012 at 05:48:43PM +0530, Tushar Behera wrote:
> The objects allocated by devm_* APIs are managed by devres and are
> freed when the device is detached. Hence there is no need to remove
> them explicitly in remove function.
>
> Signed-off-by: Tushar Behera <[email protected]>
> ---
> drivers/mfd/ab8500-core.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/