The patch series fixes 2 issues with pincfg.
- first issue is that on lan966x uses different offsets than sparx5
so it can't use directly the ocelot_confops
- second issue is pincfg stop working when regmap support was added.
v4->v5:
- add Reviewed-by, Acked-by tags for patch 2
- clean the indentation mess inside ocelot_pinconf_set
v3->v4:
- add missing check for NULL pointer when doing devm_kmemdup
- remove devm_kmemdup for pincfg_data as it can be const
- remove has_schmitt field, because we can use schmitt_bit for checking
if it has support for PIN_CONFIG_INPUT_SCHMITT_ENABLE
- change the declaration of ocelot_pinctrl_create_pincfg
v2->v3:
- reorder ocelot_pincfg_data fields, mandatory fields go first
- move the field pincfg_data inside ocelot_pinctrl
- add back max_register for regmap_config for pincfg.
- make struct ocelot_match_data const and drop the cast.
v1->v2:
- use regmap_get_reg_stride instead of making regmap_config global
- update how ocelot_match_data structs are initialized
Horatiu Vultur (2):
pinctrl: ocelot: Fix pincfg for lan966x
pinctrl: ocelot: Fix pincfg
drivers/pinctrl/pinctrl-ocelot.c | 214 ++++++++++++++++++++-----------
1 file changed, 137 insertions(+), 77 deletions(-)
--
2.33.0
On Wed, Jul 13, 2022 at 9:33 PM Horatiu Vultur
<[email protected]> wrote:
> The patch series fixes 2 issues with pincfg.
> - first issue is that on lan966x uses different offsets than sparx5
> so it can't use directly the ocelot_confops
> - second issue is pincfg stop working when regmap support was added.
v5 applied for fixes!
Thanks for fixing this Horatiu!
Thanks to Andy for the usual first-class review as well.
Yours,
Linus Walleij