2024-04-15 14:31:58

by Herman van Hazendonk

[permalink] [raw]
Subject: [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901

The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
and HP TouchPad. It works the same as all others, so just add the
compatible string for this variant.

Signed-off-by: Herman van Hazendonk <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
index fe717d8d4798..43146709e204 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
@@ -35,6 +35,7 @@ properties:
- qcom,pm8038-mpp
- qcom,pm8058-mpp
- qcom,pm8821-mpp
+ - qcom,pm8901-mpp
- qcom,pm8917-mpp
- qcom,pm8921-mpp
- const: qcom,ssbi-mpp


2024-04-17 07:06:02

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901

On Mon, 15 Apr 2024 at 17:28, Herman van Hazendonk
<[email protected]> wrote:
>
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
>
> Signed-off-by: Herman van Hazendonk <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
> 1 file changed, 1 insertion(+)

Subject should be "dt-bindings: pinctrl: qcom,pmic-mpp: ..... "

>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> index fe717d8d4798..43146709e204 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> @@ -35,6 +35,7 @@ properties:
> - qcom,pm8038-mpp
> - qcom,pm8058-mpp
> - qcom,pm8821-mpp
> + - qcom,pm8901-mpp
> - qcom,pm8917-mpp
> - qcom,pm8921-mpp
> - const: qcom,ssbi-mpp
>


--
With best wishes
Dmitry

2024-04-17 07:36:53

by Herman van Hazendonk

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-mpp: add support for PM8901

The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
and HP TouchPad. It works the same as all others, so just add the
compatible string for this variant.

Signed-off-by: Herman van Hazendonk <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
index fe717d8d4798..43146709e204 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
@@ -35,6 +35,7 @@ properties:
- qcom,pm8038-mpp
- qcom,pm8058-mpp
- qcom,pm8821-mpp
+ - qcom,pm8901-mpp
- qcom,pm8917-mpp
- qcom,pm8921-mpp
- const: qcom,ssbi-mpp

2024-04-17 09:27:21

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901

On Mon, Apr 15, 2024 at 4:17 PM Herman van Hazendonk
<[email protected]> wrote:

> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
>
> Signed-off-by: Herman van Hazendonk <[email protected]>

Patch applied, fixing subject.

Yours,
Linus Walleij

2024-04-17 14:16:43

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901

On 15/04/2024 16:17, Herman van Hazendonk wrote:
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
>
> Signed-off-by: Herman van Hazendonk <[email protected]>
> ---

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.


Best regards,
Krzysztof


2024-04-17 19:04:16

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-mpp: add support for PM8901

On Wed, Apr 17, 2024 at 09:35:32AM +0200, Herman van Hazendonk wrote:
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.

Please slow down the pace of your reposting giving people time to
respond. People work in different timezones, get busy with their own
stuff, travel to conferences, etc. As you see here, Linus fixed it up
and there was no need to even post a new version.

Also, don't send new versions as replies to the prior version. Start a
new thread.

Rob