2024-02-21 06:41:12

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] irqchip: vic: fix a kernel-doc warning

Drop one extraneous struct member to quieten a warning:

drivers/irqchip/irq-vic.c:73: warning: Excess struct member 'parent_irq' description in 'vic_device'

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: [email protected]
Cc: Thomas Gleixner <[email protected]>
---
drivers/irqchip/irq-vic.c | 1 -
1 file changed, 1 deletion(-)

diff -- a/drivers/irqchip/irq-vic.c b/drivers/irqchip/irq-vic.c
--- a/drivers/irqchip/irq-vic.c
+++ b/drivers/irqchip/irq-vic.c
@@ -47,7 +47,6 @@

/**
* struct vic_device - VIC PM device
- * @parent_irq: The parent IRQ number of the VIC if cascaded, or 0.
* @irq: The IRQ number for the base of the VIC.
* @base: The register base for the VIC.
* @valid_sources: A bitmask of valid interrupts


Subject: [tip: irq/core] irqchip/vic: Fix a kernel-doc warning

The following commit has been merged into the irq/core branch of tip:

Commit-ID: eb0e1ebb1772302213f4882f5fada2b3f6362e66
Gitweb: https://git.kernel.org/tip/eb0e1ebb1772302213f4882f5fada2b3f6362e66
Author: Randy Dunlap <[email protected]>
AuthorDate: Tue, 20 Feb 2024 22:41:04 -08:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Wed, 21 Feb 2024 18:31:08 +01:00

irqchip/vic: Fix a kernel-doc warning

Drop one extraneous struct member to quieten a warning:

drivers/irqchip/irq-vic.c:73: warning: Excess struct member 'parent_irq' description in 'vic_device'

Signed-off-by: Randy Dunlap <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-vic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-vic.c b/drivers/irqchip/irq-vic.c
index 9e3d556..ea93e72 100644
--- a/drivers/irqchip/irq-vic.c
+++ b/drivers/irqchip/irq-vic.c
@@ -47,9 +47,8 @@

/**
* struct vic_device - VIC PM device
- * @parent_irq: The parent IRQ number of the VIC if cascaded, or 0.
- * @irq: The IRQ number for the base of the VIC.
* @base: The register base for the VIC.
+ * @irq: The IRQ number for the base of the VIC.
* @valid_sources: A bitmask of valid interrupts
* @resume_sources: A bitmask of interrupts for resume.
* @resume_irqs: The IRQs enabled for resume.

2024-02-22 00:10:45

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] irqchip: vic: fix a kernel-doc warning

On Wed, Feb 21, 2024 at 7:41 AM Randy Dunlap <[email protected]> wrote:

> Drop one extraneous struct member to quieten a warning:
>
> drivers/irqchip/irq-vic.c:73: warning: Excess struct member 'parent_irq' description in 'vic_device'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: [email protected]
> Cc: Thomas Gleixner <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij