2022-02-24 09:51:20

by Prathamesh Shete

[permalink] [raw]
Subject: [PATCH] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

From: Manish Bhardwaj <[email protected]>

Using this patch we are adding PMC compatible string for
Tegra234 in GPIO driver so the irq hierarchy can be set.

Signed-off-by: Manish Bhardwaj <[email protected]>
Signed-off-by: Prathamesh Shete <[email protected]>
---
drivers/gpio/gpio-tegra186.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
index d38980b9923a..c1e9dd8c78f8 100644
--- a/drivers/gpio/gpio-tegra186.c
+++ b/drivers/gpio/gpio-tegra186.c
@@ -563,6 +563,7 @@ static unsigned int tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip,
static const struct of_device_id tegra186_pmc_of_match[] = {
{ .compatible = "nvidia,tegra186-pmc" },
{ .compatible = "nvidia,tegra194-pmc" },
+ { .compatible = "nvidia,tegra234-pmc" },
{ /* sentinel */ }
};

--
2.17.1


2022-02-24 16:40:54

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

On Thu, Feb 24, 2022 at 01:54:09PM +0530, Prathamesh Shete wrote:
> From: Manish Bhardwaj <[email protected]>
>
> Using this patch we are adding PMC compatible string for
> Tegra234 in GPIO driver so the irq hierarchy can be set.

s/irq/IRQ/, but otherwise looks good:

Acked-by: Thierry Reding <[email protected]>


Attachments:
(No filename) (329.00 B)
signature.asc (849.00 B)
Download all attachments

2022-08-16 11:23:18

by Prathamesh Shete

[permalink] [raw]
Subject: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

Using this patch we are adding PMC compatible string for
Tegra234 in GPIO driver so the IRQ hierarchy can be set.

Signed-off-by: Manish Bhardwaj <[email protected]>
Signed-off-by: Prathamesh Shete <[email protected]>
---
drivers/gpio/gpio-tegra186.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
index 54d9fa7da9c1..824a355ff27a 100644
--- a/drivers/gpio/gpio-tegra186.c
+++ b/drivers/gpio/gpio-tegra186.c
@@ -669,6 +669,7 @@ static unsigned int tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip,
static const struct of_device_id tegra186_pmc_of_match[] = {
{ .compatible = "nvidia,tegra186-pmc" },
{ .compatible = "nvidia,tegra194-pmc" },
+ { .compatible = "nvidia,tegra234-pmc" },
{ /* sentinel */ }
};

--
2.17.1

2022-09-08 10:54:14

by Prathamesh Shete

[permalink] [raw]
Subject: RE: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

Hi
Can you please help review this patch

Thanks
Prathamesh.

> -----Original Message-----
> From: Prathamesh Shete <[email protected]>
> Sent: Tuesday, August 16, 2022 3:57 PM
> To: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]; Jonathan Hunter <[email protected]>;
> [email protected]
> Cc: Suresh Mangipudi <[email protected]>; Prathamesh Shete
> <[email protected]>; Manish Bhardwaj <[email protected]>
> Subject: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO
> driver
>
> Using this patch we are adding PMC compatible string for
> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
>
> Signed-off-by: Manish Bhardwaj <[email protected]>
> Signed-off-by: Prathamesh Shete <[email protected]>
> ---
> drivers/gpio/gpio-tegra186.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c index
> 54d9fa7da9c1..824a355ff27a 100644
> --- a/drivers/gpio/gpio-tegra186.c
> +++ b/drivers/gpio/gpio-tegra186.c
> @@ -669,6 +669,7 @@ static unsigned int
> tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip, static const struct
> of_device_id tegra186_pmc_of_match[] = {
> { .compatible = "nvidia,tegra186-pmc" },
> { .compatible = "nvidia,tegra194-pmc" },
> + { .compatible = "nvidia,tegra234-pmc" },
> { /* sentinel */ }
> };
>
> --
> 2.17.1

2022-09-08 13:29:31

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

On Tue, Aug 16, 2022 at 12:27 PM Prathamesh Shete <[email protected]> wrote:

> Using this patch we are adding PMC compatible string for
> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
>
> Signed-off-by: Manish Bhardwaj <[email protected]>
> Signed-off-by: Prathamesh Shete <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

It also has Thierry's ACK from v1.

Yours,
Linus Walleij

2022-09-15 13:07:18

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

On Tue, Aug 16, 2022 at 03:57:25PM +0530, Prathamesh Shete wrote:
> Using this patch we are adding PMC compatible string for
> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
>
> Signed-off-by: Manish Bhardwaj <[email protected]>
> Signed-off-by: Prathamesh Shete <[email protected]>
> ---
> drivers/gpio/gpio-tegra186.c | 1 +
> 1 file changed, 1 insertion(+)

I already acked this on v1, but here goes again, for patchwork:

Acked-by: Thierry Reding <[email protected]>


Attachments:
(No filename) (500.00 B)
signature.asc (849.00 B)
Download all attachments

2023-01-09 20:46:18

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

Hi Linus,

On 08/09/2022 14:21, Linus Walleij wrote:
> On Tue, Aug 16, 2022 at 12:27 PM Prathamesh Shete <[email protected]> wrote:
>
>> Using this patch we are adding PMC compatible string for
>> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
>>
>> Signed-off-by: Manish Bhardwaj <[email protected]>
>> Signed-off-by: Prathamesh Shete <[email protected]>
>
> Reviewed-by: Linus Walleij <[email protected]>
>
> It also has Thierry's ACK from v1.
>
> Yours,
> Linus Walleij


I don't see this one in -next. Are you able to pick this up?

Reviewed-by: Jon Hunter <[email protected]>
Tested-by: Jon Hunter <[email protected]>

Thanks!
Jon

2023-01-10 08:37:50

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

On Mon, Jan 9, 2023 at 9:37 PM Jon Hunter <[email protected]> wrote:
> On 08/09/2022 14:21, Linus Walleij wrote:
> > On Tue, Aug 16, 2022 at 12:27 PM Prathamesh Shete <[email protected]> wrote:
> >
> >> Using this patch we are adding PMC compatible string for
> >> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
> >>
> >> Signed-off-by: Manish Bhardwaj <[email protected]>
> >> Signed-off-by: Prathamesh Shete <[email protected]>
> >
> > Reviewed-by: Linus Walleij <[email protected]>
> >
> > It also has Thierry's ACK from v1.
> >
> > Yours,
> > Linus Walleij
>
>
> I don't see this one in -next. Are you able to pick this up?
>
> Reviewed-by: Jon Hunter <[email protected]>
> Tested-by: Jon Hunter <[email protected]>

Bartosz is queueing GPIO patches right now, but the mail has the
wrong address for him.

I put the new mail address in To, so he can pick it up.

Yours,
Linus Walleij

2023-01-11 08:54:46

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

On Tue, Jan 10, 2023 at 9:24 AM Linus Walleij <[email protected]> wrote:
>
> On Mon, Jan 9, 2023 at 9:37 PM Jon Hunter <[email protected]> wrote:
> > On 08/09/2022 14:21, Linus Walleij wrote:
> > > On Tue, Aug 16, 2022 at 12:27 PM Prathamesh Shete <[email protected]> wrote:
> > >
> > >> Using this patch we are adding PMC compatible string for
> > >> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
> > >>
> > >> Signed-off-by: Manish Bhardwaj <[email protected]>
> > >> Signed-off-by: Prathamesh Shete <[email protected]>
> > >
> > > Reviewed-by: Linus Walleij <[email protected]>
> > >
> > > It also has Thierry's ACK from v1.
> > >
> > > Yours,
> > > Linus Walleij
> >
> >
> > I don't see this one in -next. Are you able to pick this up?
> >
> > Reviewed-by: Jon Hunter <[email protected]>
> > Tested-by: Jon Hunter <[email protected]>
>
> Bartosz is queueing GPIO patches right now, but the mail has the
> wrong address for him.
>
> I put the new mail address in To, so he can pick it up.
>

Come on, my address changed 18 months ago, re-run get_maintainers.pl
from time to time. :)

Now applied, thanks!

Bart