2019-01-29 16:57:57

by J. Neuschäfer

[permalink] [raw]
Subject: [PATCH] dt-bindings: pinctrl: Document the i.MX50 IOMUXC binding

AFAICS from the i.MX50 Reference Manual, the i.MX50 IOMUXC works the
same as the one in i.MX51, so I copied fsl,imx51-pinctrl.txt and changed
the text to imx50.

Signed-off-by: Jonathan Neuschäfer <[email protected]>
Cc: Dong Aisheng <[email protected]>
Cc: Shawn Guo <[email protected]>
---
.../bindings/pinctrl/fsl,imx50-pinctrl.txt | 32 +++++++++++++++++++
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx50-pinctrl.txt

diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx50-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx50-pinctrl.txt
new file mode 100644
index 000000000000..6da01d619d33
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx50-pinctrl.txt
@@ -0,0 +1,32 @@
+* Freescale IMX50 IOMUX Controller
+
+Please refer to fsl,imx-pinctrl.txt in this directory for common binding part
+and usage.
+
+Required properties:
+- compatible: "fsl,imx50-iomuxc"
+- fsl,pins: two integers array, represents a group of pins mux and config
+ setting. The format is fsl,pins = <PIN_FUNC_ID CONFIG>, PIN_FUNC_ID is a
+ pin working on a specific function, CONFIG is the pad setting value like
+ pull-up for this pin. Please refer to imx50 datasheet for the valid pad
+ config settings.
+
+CONFIG bits definition:
+PAD_CTL_HVE (1 << 13)
+PAD_CTL_HYS (1 << 8)
+PAD_CTL_PKE (1 << 7)
+PAD_CTL_PUE (1 << 6)
+PAD_CTL_PUS_100K_DOWN (0 << 4)
+PAD_CTL_PUS_47K_UP (1 << 4)
+PAD_CTL_PUS_100K_UP (2 << 4)
+PAD_CTL_PUS_22K_UP (3 << 4)
+PAD_CTL_ODE (1 << 3)
+PAD_CTL_DSE_LOW (0 << 1)
+PAD_CTL_DSE_MED (1 << 1)
+PAD_CTL_DSE_HIGH (2 << 1)
+PAD_CTL_DSE_MAX (3 << 1)
+PAD_CTL_SRE_FAST (1 << 0)
+PAD_CTL_SRE_SLOW (0 << 0)
+
+Refer to imx50-pinfunc.h in device tree source folder for all available
+imx50 PIN_FUNC_ID.
--
2.20.1



2019-02-08 11:36:51

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: pinctrl: Document the i.MX50 IOMUXC binding

On Tue, Jan 29, 2019 at 5:55 PM Jonathan Neuschäfer
<[email protected]> wrote:

> AFAICS from the i.MX50 Reference Manual, the i.MX50 IOMUXC works the
> same as the one in i.MX51, so I copied fsl,imx51-pinctrl.txt and changed
> the text to imx50.
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>
> Cc: Dong Aisheng <[email protected]>
> Cc: Shawn Guo <[email protected]>

i.MX people. can you please look at this patch?

Yours,
Linus Walleij

2019-02-08 11:59:05

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: pinctrl: Document the i.MX50 IOMUXC binding

Hi Jonathan,

On Tue, Jan 29, 2019 at 2:55 PM Jonathan Neuschäfer
<[email protected]> wrote:
>
> AFAICS from the i.MX50 Reference Manual, the i.MX50 IOMUXC works the
> same as the one in i.MX51, so I copied fsl,imx51-pinctrl.txt and changed
> the text to imx50.
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>
> Cc: Dong Aisheng <[email protected]>
> Cc: Shawn Guo <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>

> +Required properties:
> +- compatible: "fsl,imx50-iomuxc"
> +- fsl,pins: two integers array, represents a group of pins mux and config
> + setting. The format is fsl,pins = <PIN_FUNC_ID CONFIG>, PIN_FUNC_ID is a
> + pin working on a specific function, CONFIG is the pad setting value like
> + pull-up for this pin. Please refer to imx50 datasheet for the valid pad

Nit: It is the i.MX50 Reference Manual, not its datasheet that
describes the pad settings values.

I noticed that all the bindings say datasheet though, so I will send a
patch to fix this.

2019-02-08 15:49:39

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: pinctrl: Document the i.MX50 IOMUXC binding

On Fri, Feb 08, 2019 at 09:57:04AM -0200, Fabio Estevam wrote:
> Hi Jonathan,
>
> On Tue, Jan 29, 2019 at 2:55 PM Jonathan Neuschäfer
> <[email protected]> wrote:
> >
> > AFAICS from the i.MX50 Reference Manual, the i.MX50 IOMUXC works the
> > same as the one in i.MX51, so I copied fsl,imx51-pinctrl.txt and changed
> > the text to imx50.
> >
> > Signed-off-by: Jonathan Neuschäfer <[email protected]>
> > Cc: Dong Aisheng <[email protected]>
> > Cc: Shawn Guo <[email protected]>
>
> Reviewed-by: Fabio Estevam <[email protected]>

Thanks!

> > +Required properties:
> > +- compatible: "fsl,imx50-iomuxc"
> > +- fsl,pins: two integers array, represents a group of pins mux and config
> > + setting. The format is fsl,pins = <PIN_FUNC_ID CONFIG>, PIN_FUNC_ID is a
> > + pin working on a specific function, CONFIG is the pad setting value like
> > + pull-up for this pin. Please refer to imx50 datasheet for the valid pad
>
> Nit: It is the i.MX50 Reference Manual, not its datasheet that
> describes the pad settings values.

Indeed, good catch.

> I noticed that all the bindings say datasheet though, so I will send a
> patch to fix this.

Thanks!


Jonathan Neuschäfer


Attachments:
(No filename) (1.21 kB)
signature.asc (849.00 B)
Download all attachments

2019-02-21 12:39:17

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: pinctrl: Document the i.MX50 IOMUXC binding

On Tue, Jan 29, 2019 at 5:55 PM Jonathan Neuschäfer
<[email protected]> wrote:

> AFAICS from the i.MX50 Reference Manual, the i.MX50 IOMUXC works the
> same as the one in i.MX51, so I copied fsl,imx51-pinctrl.txt and changed
> the text to imx50.
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>
> Cc: Dong Aisheng <[email protected]>
> Cc: Shawn Guo <[email protected]>

Patch applied with Fabio's review tag.

Yours,
Linus Walleij