2021-11-04 17:09:46

by Bjorn Andersson

Subject: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets

The downstream TLMM binding covers a group of TLMM-related hardware
blocks, but the upstream binding only captures the particular block
related to controlling the TLMM pins from an OS. In the translation of
the driver from downstream, the offset of 0x100000 was lost for the UFS
and SDC pingroups.

Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
index 4d8f8636c2b3..1c042d39380c 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
@@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
[200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
[201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
[202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
- [203] = UFS_RESET(ufs_reset, 0x1d8000),
- [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
- [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
- [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
+ [203] = UFS_RESET(ufs_reset, 0xd8000),
+ [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
+ [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
+ [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
};

static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {
--
2.33.1

2021-11-06 22:32:11

by Vladimir Zapolskiy

Subject: Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets

On 11/4/21 7:08 PM, Bjorn Andersson wrote:
> The downstream TLMM binding covers a group of TLMM-related hardware
> blocks, but the upstream binding only captures the particular block
> related to controlling the TLMM pins from an OS. In the translation of
> the driver from downstream, the offset of 0x100000 was lost for the UFS
> and SDC pingroups.
>
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> index 4d8f8636c2b3..1c042d39380c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
> [200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
> [201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
> [202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
> - [203] = UFS_RESET(ufs_reset, 0x1d8000),
> - [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
> - [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
> - [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
> + [203] = UFS_RESET(ufs_reset, 0xd8000),
> + [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
> + [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
> + [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
> };
>
> static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {
>

Reviewed-by: Vladimir Zapolskiy <[email protected]>

--
Best wishes,
Vladimir

2021-11-09 14:59:56

by Vinod Koul

Subject: Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets

On 04-11-21, 10:08, Bjorn Andersson wrote:
> The downstream TLMM binding covers a group of TLMM-related hardware
> blocks, but the upstream binding only captures the particular block
> related to controlling the TLMM pins from an OS. In the translation of
> the driver from downstream, the offset of 0x100000 was lost for the UFS
> and SDC pingroups.
>
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> index 4d8f8636c2b3..1c042d39380c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
> [200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
> [201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
> [202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
> - [203] = UFS_RESET(ufs_reset, 0x1d8000),
> - [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
> - [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
> - [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
> + [203] = UFS_RESET(ufs_reset, 0xd8000),
> + [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
> + [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
> + [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),

Right, these are the offsets defined in the the documentation, sorry to
have missed updating here

Reviewed-by: Vinod Koul <[email protected]>

--
~Vinod

2021-11-09 23:11:39

by Linus Walleij

Subject: Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets

On Thu, Nov 4, 2021 at 6:06 PM Bjorn Andersson
<[email protected]> wrote:

> The downstream TLMM binding covers a group of TLMM-related hardware
> blocks, but the upstream binding only captures the particular block
> related to controlling the TLMM pins from an OS. In the translation of
> the driver from downstream, the offset of 0x100000 was lost for the UFS
> and SDC pingroups.
>
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Signed-off-by: Bjorn Andersson <[email protected]>

Patch applied for fixes.

Yours,
Linus Walleij