2020-09-30 09:23:55

by Mike Looijmans

[permalink] [raw]
Subject: [PATCH v2 2/2] gpio: pca953x: Add support for the NXP PCAL9554B/C

The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
with 8 GPIOs, latched interrupts and some advanced configuration
options. The "C" version only differs in I2C address.

Signed-off-by: Mike Looijmans <[email protected]>
---
v2: Split devicetree and code into separate patches

drivers/gpio/gpio-pca953x.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index bd2e96c34f82..fb946b01512d 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -90,6 +90,7 @@ static const struct i2c_device_id pca953x_id[] = {
{ "pcal6416", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
{ "pcal6524", 24 | PCA953X_TYPE | PCA_LATCH_INT, },
{ "pcal9535", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
+ { "pcal9554b", 8 | PCA953X_TYPE | PCA_LATCH_INT, },
{ "pcal9555a", 16 | PCA953X_TYPE | PCA_LATCH_INT, },

{ "max7310", 8 | PCA953X_TYPE, },
@@ -1237,6 +1238,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
{ .compatible = "nxp,pcal6416", .data = OF_953X(16, PCA_LATCH_INT), },
{ .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_LATCH_INT), },
{ .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
+ { .compatible = "nxp,pcal9554b", .data = OF_953X( 8, PCA_LATCH_INT), },
{ .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_LATCH_INT), },

{ .compatible = "maxim,max7310", .data = OF_953X( 8, 0), },
--
2.17.1


2020-09-30 09:44:20

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] gpio: pca953x: Add support for the NXP PCAL9554B/C

On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <[email protected]> wrote:
>
> The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
> with 8 GPIOs, latched interrupts and some advanced configuration
> options. The "C" version only differs in I2C address.
>
> Signed-off-by: Mike Looijmans <[email protected]>
> ---

Reviewed-by: Bartosz Golaszewski <[email protected]>

I'll let Linus pick it up, I already sent my final PR for v5.10.

Bartosz

2020-09-30 09:52:46

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] gpio: pca953x: Add support for the NXP PCAL9554B/C

On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <[email protected]> wrote:

> The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
> with 8 GPIOs, latched interrupts and some advanced configuration
> options. The "C" version only differs in I2C address.
>
> Signed-off-by: Mike Looijmans <[email protected]>
> ---
> v2: Split devicetree and code into separate patches

Patch applied.

Yours,
Linus Walleij