2023-07-20 12:19:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply

According to bindings and Linux driver, there is no VDDIO but VIO
supply:

ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
index 37e59403c01f..469e61c9a349 100644
--- a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
+++ b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
@@ -192,7 +192,7 @@ synaptics@4b {
#size-cells = <0>;
reg = <0x4b>;
vdd-supply = <&ab8500_ldo_aux1_reg>;
- vddio-supply = <&db8500_vsmps2_reg>;
+ vio-supply = <&db8500_vsmps2_reg>;
pinctrl-names = "default";
pinctrl-0 = <&synaptics_tvk_mode>;
interrupt-parent = <&gpio2>;
--
2.34.1



2023-07-20 12:29:11

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] ARM: dts: st: href-tvk1281618: correct touchscreen syna,nosleep-mode

There is no syna,nosleep property in Synaptics RMI4 touchscreen:

ste-hrefprev60-tvk.dtb: synaptics@4b: rmi4-f01@1: 'syna,nosleep' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
index 469e61c9a349..7448135e25f6 100644
--- a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
+++ b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
@@ -200,7 +200,7 @@ synaptics@4b {

rmi4-f01@1 {
reg = <0x1>;
- syna,nosleep = <1>;
+ syna,nosleep-mode = <1>;
};
rmi4-f11@11 {
reg = <0x11>;
--
2.34.1


2023-08-10 08:33:36

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 2/2] ARM: dts: st: href-tvk1281618: correct touchscreen syna,nosleep-mode

On Thu, Jul 20, 2023 at 1:55 PM Krzysztof Kozlowski
<[email protected]> wrote:

> There is no syna,nosleep property in Synaptics RMI4 touchscreen:
>
> ste-hrefprev60-tvk.dtb: synaptics@4b: rmi4-f01@1: 'syna,nosleep' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Patch applied!

Yours,
Linus Walleij

2023-08-10 08:53:13

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply

On Thu, Jul 20, 2023 at 1:55 PM Krzysztof Kozlowski
<[email protected]> wrote:

> According to bindings and Linux driver, there is no VDDIO but VIO
> supply:
>
> ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Patch applied!
Excellently shows how the schema files find real bugs in the DTS files!

Yours,
Linus Walleij

2023-09-24 22:41:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply

On 10/08/2023 09:54, Linus Walleij wrote:
> On Thu, Jul 20, 2023 at 1:55 PM Krzysztof Kozlowski
> <[email protected]> wrote:
>
>> According to bindings and Linux driver, there is no VDDIO but VIO
>> supply:
>>
>> ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Patch applied!
> Excellently shows how the schema files find real bugs in the DTS files!

It seems it is not in the linux-next (one month later). Shall I take it?

Best regards,
Krzysztof

2023-09-25 10:33:37

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply

On Sun, Sep 24, 2023 at 8:55 PM Krzysztof Kozlowski
<[email protected]> wrote:

> > Patch applied!
> > Excellently shows how the schema files find real bugs in the DTS files!
>
> It seems it is not in the linux-next (one month later). Shall I take it?

Ooops. Just me not keeping track of my TODO list as usual.
Sent a pull request now.

Yours,
Linus Walleij