2023-06-04 13:26:47

by Andy Shevchenko

Subject: [PATCH v1 2/2] pinctrl: Relax user input size in pinmux_select()

This is debugfs and there is no much sense to strict the user from
sending as much data as they can. The memdup_user_nul() will anyway
fail if there is not enough memory.

Relax the user input size by removing an artificial limitaion.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/pinctrl/pinmux.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index 2d2f3bd164d5..82c750a31952 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -677,7 +677,6 @@ void pinmux_show_setting(struct seq_file *s,
DEFINE_SHOW_ATTRIBUTE(pinmux_functions);
DEFINE_SHOW_ATTRIBUTE(pinmux_pins);

-#define PINMUX_SELECT_MAX 128
static ssize_t pinmux_select(struct file *file, const char __user *user_buf,
size_t len, loff_t *ppos)
{
@@ -689,9 +688,6 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf,
unsigned int num_groups;
int fsel, gsel, ret;

- if (len > PINMUX_SELECT_MAX)
- return -ENOMEM;
-
buf = memdup_user_nul(user_buf, len);
if (IS_ERR(buf))
return PTR_ERR(buf);
--
2.40.0.1.gaa8946217a0b

2023-06-09 07:30:34

by Linus Walleij

Subject: Re: [PATCH v1 2/2] pinctrl: Relax user input size in pinmux_select()

On Sun, Jun 4, 2023 at 3:12 PM Andy Shevchenko
<[email protected]> wrote:

> This is debugfs and there is no much sense to strict the user from
> sending as much data as they can. The memdup_user_nul() will anyway
> fail if there is not enough memory.
>
> Relax the user input size by removing an artificial limitaion.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Fair enough, patch applied!

Yours,
Linus Walleij