2013-07-22 01:22:07

by Fabio Estevam

Subject: [PATCH] pinctrl: pinctrl-imx: Remove unneeded check for platform_get_resource()

From: Fabio Estevam <[email protected]>

As devm_ioremap_resource() is used on probe, there is no need to explicitly
check the return value from platform_get_resource(), as this is something that
devm_ioremap_resource() takes care by itself.

Signed-off-by: Fabio Estevam <[email protected]>
---
drivers/pinctrl/pinctrl-imx.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index 57a4eb0..dea739a 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
@@ -580,9 +580,6 @@ int imx_pinctrl_probe(struct platform_device *pdev,
return -ENOMEM;

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENOENT;
-
ipctl->base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(ipctl->base))
return PTR_ERR(ipctl->base);
--
1.8.1.2

2013-07-22 13:04:20

by Shawn Guo

Subject: Re: [PATCH] pinctrl: pinctrl-imx: Remove unneeded check for platform_get_resource()

On Sun, Jul 21, 2013 at 10:16:21PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> As devm_ioremap_resource() is used on probe, there is no need to explicitly
> check the return value from platform_get_resource(), as this is something that
> devm_ioremap_resource() takes care by itself.
>
> Signed-off-by: Fabio Estevam <[email protected]>

Acked-by: Shawn Guo <[email protected]>

2013-07-22 23:21:13

by Linus Walleij

Subject: Re: [PATCH] pinctrl: pinctrl-imx: Remove unneeded check for platform_get_resource()

On Mon, Jul 22, 2013 at 3:16 AM, Fabio Estevam <[email protected]> wrote:

> From: Fabio Estevam <[email protected]>
>
> As devm_ioremap_resource() is used on probe, there is no need to explicitly
> check the return value from platform_get_resource(), as this is something that
> devm_ioremap_resource() takes care by itself.
>
> Signed-off-by: Fabio Estevam <[email protected]>

Applied with Shawn's ACK.

Yours,
Linus Walleij