2021-03-23 06:28:08

by Tim Yang

[permalink] [raw]
Subject: [PATCH] kernel: kcov: fix a typo in comment

Fixed a typo in comment.

Signed-off-by: tl455047 <[email protected]>
---
kernel/kcov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kcov.c b/kernel/kcov.c
index 80bfe71bbe13..6f59842f2caf 100644
--- a/kernel/kcov.c
+++ b/kernel/kcov.c
@@ -527,7 +527,7 @@ static int kcov_get_mode(unsigned long arg)

/*
* Fault in a lazily-faulted vmalloc area before it can be used by
- * __santizer_cov_trace_pc(), to avoid recursion issues if any code on the
+ * __sanitizer_cov_trace_pc(), to avoid recursion issues if any code on the
* vmalloc fault handling path is instrumented.
*/
static void kcov_fault_in_area(struct kcov *kcov)
--
2.25.1


2021-03-23 06:48:59

by Dmitry Vyukov

[permalink] [raw]
Subject: Re: [PATCH] kernel: kcov: fix a typo in comment

On Tue, Mar 23, 2021 at 7:24 AM tl455047 <[email protected]> wrote:
>
> Fixed a typo in comment.
>
> Signed-off-by: tl455047 <[email protected]>

Reviewed-by: Dmitry Vyukov <[email protected]>

+Andrew, linux-mm as KCOV patches are generally merged into mm.

Thanks for the fix

> ---
> kernel/kcov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kcov.c b/kernel/kcov.c
> index 80bfe71bbe13..6f59842f2caf 100644
> --- a/kernel/kcov.c
> +++ b/kernel/kcov.c
> @@ -527,7 +527,7 @@ static int kcov_get_mode(unsigned long arg)
>
> /*
> * Fault in a lazily-faulted vmalloc area before it can be used by
> - * __santizer_cov_trace_pc(), to avoid recursion issues if any code on the
> + * __sanitizer_cov_trace_pc(), to avoid recursion issues if any code on the
> * vmalloc fault handling path is instrumented.
> */
> static void kcov_fault_in_area(struct kcov *kcov)
> --
> 2.25.1
>

2021-03-23 22:36:32

by Marco Elver

[permalink] [raw]
Subject: Re: [PATCH] kernel: kcov: fix a typo in comment

On Tue, 23 Mar 2021 at 07:45, 'Dmitry Vyukov' via kasan-dev
<[email protected]> wrote:
> On Tue, Mar 23, 2021 at 7:24 AM tl455047 <[email protected]> wrote:
> >
> > Fixed a typo in comment.
> >
> > Signed-off-by: tl455047 <[email protected]>
>
> Reviewed-by: Dmitry Vyukov <[email protected]>
>
> +Andrew, linux-mm as KCOV patches are generally merged into mm.
>
> Thanks for the fix

FYI, I believe this code may not be accepted due to this:

"[...] It is imperative that all code contributed to the kernel be legitimately
free software. For that reason, code from anonymous (or pseudonymous)
contributors will not be accepted."

See Documentation/process/1.Intro.rst

2021-03-25 03:34:06

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] kernel: kcov: fix a typo in comment

On Tue, 23 Mar 2021 23:32:57 +0100 Marco Elver <[email protected]> wrote:

> On Tue, 23 Mar 2021 at 07:45, 'Dmitry Vyukov' via kasan-dev
> <[email protected]> wrote:
> > On Tue, Mar 23, 2021 at 7:24 AM tl455047 <[email protected]> wrote:
> > >
> > > Fixed a typo in comment.
> > >
> > > Signed-off-by: tl455047 <[email protected]>
> >
> > Reviewed-by: Dmitry Vyukov <[email protected]>
> >
> > +Andrew, linux-mm as KCOV patches are generally merged into mm.
> >
> > Thanks for the fix
>
> FYI, I believe this code may not be accepted due to this:
>
> "[...] It is imperative that all code contributed to the kernel be legitimately
> free software. For that reason, code from anonymous (or pseudonymous)
> contributors will not be accepted."
>
> See Documentation/process/1.Intro.rst

Correct. I let this one pass because the patch is so minor. But yes,
a real name would be preferred, please.

2021-03-25 03:34:31

by Marco Elver

[permalink] [raw]
Subject: Re: [PATCH] kernel: kcov: fix a typo in comment

On Thu, 25 Mar 2021 at 00:04, Andrew Morton <[email protected]> wrote:
> On Tue, 23 Mar 2021 23:32:57 +0100 Marco Elver <[email protected]> wrote:
> > On Tue, 23 Mar 2021 at 07:45, 'Dmitry Vyukov' via kasan-dev
> > <[email protected]> wrote:
> > > On Tue, Mar 23, 2021 at 7:24 AM tl455047 <[email protected]> wrote:
> > > >
> > > > Fixed a typo in comment.
> > > >
> > > > Signed-off-by: tl455047 <[email protected]>
> > >
> > > Reviewed-by: Dmitry Vyukov <[email protected]>
> > >
> > > +Andrew, linux-mm as KCOV patches are generally merged into mm.
> > >
> > > Thanks for the fix
> >
> > FYI, I believe this code may not be accepted due to this:
> >
> > "[...] It is imperative that all code contributed to the kernel be legitimately
> > free software. For that reason, code from anonymous (or pseudonymous)
> > contributors will not be accepted."
> >
> > See Documentation/process/1.Intro.rst
>
> Correct. I let this one pass because the patch is so minor. But yes,
> a real name would be preferred, please.

I've just seen that the author sent
https://lkml.kernel.org/r/[email protected]