>From API view, it isn't good to run all hw queues synchronously
in one context, since it isn't correct for multi hw queue case.
So this patch adds 'async' parameter to blk_mq_start_hw_queue(),
and make blk_mq_start_hw_queues() to run hw queues asynchronously
at default.
Signed-off-by: Ming Lei <[email protected]>
---
block/blk-mq.c | 6 +++---
include/linux/blk-mq.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 0ef2dc7..f83eacd 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -873,12 +873,12 @@ void blk_mq_stop_hw_queues(struct request_queue *q)
}
EXPORT_SYMBOL(blk_mq_stop_hw_queues);
-void blk_mq_start_hw_queue(struct blk_mq_hw_ctx *hctx)
+void blk_mq_start_hw_queue(struct blk_mq_hw_ctx *hctx, bool async)
{
clear_bit(BLK_MQ_S_STOPPED, &hctx->state);
preempt_disable();
- __blk_mq_run_hw_queue(hctx);
+ blk_mq_run_hw_queue(hctx, async);
preempt_enable();
}
EXPORT_SYMBOL(blk_mq_start_hw_queue);
@@ -889,7 +889,7 @@ void blk_mq_start_hw_queues(struct request_queue *q)
int i;
queue_for_each_hw_ctx(q, hctx, i)
- blk_mq_start_hw_queue(hctx);
+ blk_mq_start_hw_queue(hctx, true);
}
EXPORT_SYMBOL(blk_mq_start_hw_queues);
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index eb726b9..49e84b5 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -169,7 +169,7 @@ void blk_mq_kick_requeue_list(struct request_queue *q);
void blk_mq_complete_request(struct request *rq);
void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx);
-void blk_mq_start_hw_queue(struct blk_mq_hw_ctx *hctx);
+void blk_mq_start_hw_queue(struct blk_mq_hw_ctx *hctx, bool async);
void blk_mq_stop_hw_queues(struct request_queue *q);
void blk_mq_start_hw_queues(struct request_queue *q);
void blk_mq_start_stopped_hw_queues(struct request_queue *q, bool async);
--
1.7.9.5
On Tue, Jun 24, 2014 at 10:53 PM, Ming Lei <[email protected]> wrote:
> From API view, it isn't good to run all hw queues synchronously
> in one context, since it isn't correct for multi hw queue case.
>
> So this patch adds 'async' parameter to blk_mq_start_hw_queue(),
> and make blk_mq_start_hw_queues() to run hw queues asynchronously
> at default.
BTW, without the change, it is easy to trigger the WARN_ON() in
__blk_mq_run_hw_queue().
Thanks,
--
Ming Lei
On 2014-06-24 20:42, Ming Lei wrote:
> On Tue, Jun 24, 2014 at 10:53 PM, Ming Lei <[email protected]> wrote:
>> From API view, it isn't good to run all hw queues synchronously
>> in one context, since it isn't correct for multi hw queue case.
>>
>> So this patch adds 'async' parameter to blk_mq_start_hw_queue(),
>> and make blk_mq_start_hw_queues() to run hw queues asynchronously
>> at default.
>
> BTW, without the change, it is easy to trigger the WARN_ON() in
> __blk_mq_run_hw_queue().
Why not just have it call blk_mq_run_hw_queue()? Pass in async == false,
but let the cpumask logic sort out if we need to force an async run.
--
Jens Axboe
On Wed, Jun 25, 2014 at 11:00 AM, Jens Axboe <[email protected]> wrote:
> On 2014-06-24 20:42, Ming Lei wrote:
>>
>> On Tue, Jun 24, 2014 at 10:53 PM, Ming Lei <[email protected]> wrote:
>>>
>>> From API view, it isn't good to run all hw queues synchronously
>>> in one context, since it isn't correct for multi hw queue case.
>>>
>>> So this patch adds 'async' parameter to blk_mq_start_hw_queue(),
>>> and make blk_mq_start_hw_queues() to run hw queues asynchronously
>>> at default.
>>
>>
>> BTW, without the change, it is easy to trigger the WARN_ON() in
>> __blk_mq_run_hw_queue().
>
>
> Why not just have it call blk_mq_run_hw_queue()? Pass in async == false, but
> let the cpumask logic sort out if we need to force an async run.
That looks better, thanks.
Thanks,
--
Ming Lei