2022-04-16 00:44:08

by Hsin-Yi Wang

Subject: Re: [PATCH V3 14/15] arm64: dts: mediatek: Add MediaTek CCI node for MT8183

On Fri, Apr 15, 2022 at 1:59 PM Rex-BC Chen <[email protected]> wrote:
>
> Add MediaTek CCI devfreq node for MT8183.
>
> Signed-off-by: Andrew-sh.Cheng <[email protected]>
> Signed-off-by: Rex-BC Chen <[email protected]>
> ---
> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 4 ++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 7 +++++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> index 8953dbf84f3e..7ac9864db9de 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> @@ -412,6 +412,10 @@
>
> };
>
> +&cci {
> + proc-supply = <&mt6358_vproc12_reg>;
> +};
> +
> &cpu0 {
> proc-supply = <&mt6358_vproc12_reg>;
> };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 0f9480f91261..4786a32ee975 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -230,6 +230,10 @@
> status = "okay";
> };
>
> +&cci {
> + proc-supply = <&mt6358_vproc12_reg>;
> +};
> +
> &cpu0 {
> proc-supply = <&mt6358_vproc12_reg>;
> };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 4ae3305d16d2..334728413582 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -280,6 +280,13 @@
> };
> };
>
> + cci: cci {
> + compatible = "mediatek,mt8183-cci";
> + clocks = <&apmixedsys CLK_APMIXED_CCIPLL>;
> + clock-names = "cci_clock";
> + operating-points-v2 = <&cci_opp>;

hi Rex,

cci_opp is not defined in dts.

> + };
> +
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.18.0
>

2022-04-16 01:24:24

by Hsin-Yi Wang

Subject: Re: [PATCH V3 14/15] arm64: dts: mediatek: Add MediaTek CCI node for MT8183

On Fri, Apr 15, 2022 at 2:06 PM Hsin-Yi Wang <[email protected]> wrote:
>
> On Fri, Apr 15, 2022 at 1:59 PM Rex-BC Chen <[email protected]> wrote:
> >
> > Add MediaTek CCI devfreq node for MT8183.
> >
> > Signed-off-by: Andrew-sh.Cheng <[email protected]>
> > Signed-off-by: Rex-BC Chen <[email protected]>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 4 ++++
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 7 +++++++
> > 3 files changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > index 8953dbf84f3e..7ac9864db9de 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > @@ -412,6 +412,10 @@
> >
> > };
> >
> > +&cci {
> > + proc-supply = <&mt6358_vproc12_reg>;
> > +};
> > +
> > &cpu0 {
> > proc-supply = <&mt6358_vproc12_reg>;
> > };
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > index 0f9480f91261..4786a32ee975 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > @@ -230,6 +230,10 @@
> > status = "okay";
> > };
> >
> > +&cci {
> > + proc-supply = <&mt6358_vproc12_reg>;
> > +};
> > +
> > &cpu0 {
> > proc-supply = <&mt6358_vproc12_reg>;
> > };
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 4ae3305d16d2..334728413582 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -280,6 +280,13 @@
> > };
> > };
> >
> > + cci: cci {
> > + compatible = "mediatek,mt8183-cci";
> > + clocks = <&apmixedsys CLK_APMIXED_CCIPLL>;
> > + clock-names = "cci_clock";
> > + operating-points-v2 = <&cci_opp>;
>
> hi Rex,
>
> cci_opp is not defined in dts.
>
It's in the previous patch. Please ignore this comment.

> > + };
> > +
> > cpus {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > --
> > 2.18.0
> >