2023-02-07 09:15:00

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

There is a spelling mistake in a dev_warn message, make it lower case
and fix the spelling.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/platform/chrome/cros_ec_typec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 71f5d7d8e055..a673c3342470 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -1020,7 +1020,7 @@ static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num
cros_typec_handle_vdm_attention(typec, port_num);
ret = cros_typec_send_clear_event(typec, port_num, PD_STATUS_EVENT_VDM_ATTENTION);
if (ret < 0)
- dev_warn(typec->dev, "Failed VDM Attenetion event clear, port: %d\n",
+ dev_warn(typec->dev, "Failed VDM attention event clear, port: %d\n",
port_num);
}
}
--
2.30.2



2023-02-07 17:50:04

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH][next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

On Tue, Feb 7, 2023 at 1:14 AM Colin Ian King <[email protected]> wrote:
>
> There is a spelling mistake in a dev_warn message, make it lower case
> and fix the spelling.
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/platform/chrome/cros_ec_typec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 71f5d7d8e055..a673c3342470 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -1020,7 +1020,7 @@ static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num
> cros_typec_handle_vdm_attention(typec, port_num);
> ret = cros_typec_send_clear_event(typec, port_num, PD_STATUS_EVENT_VDM_ATTENTION);
> if (ret < 0)
> - dev_warn(typec->dev, "Failed VDM Attenetion event clear, port: %d\n",
> + dev_warn(typec->dev, "Failed VDM attention event clear, port: %d\n",
> port_num);
> }
> }
> --
> 2.30.2
>

2023-02-08 07:33:10

by Tzung-Bi Shih

[permalink] [raw]
Subject: Re: [PATCH][next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

Hi Prashant,

On Tue, Feb 07, 2023 at 09:14:43AM +0000, Colin Ian King wrote:
> There is a spelling mistake in a dev_warn message, make it lower case
> and fix the spelling.
>
> Signed-off-by: Colin Ian King <[email protected]>

It's about time to cut for the coming merge window. I guess you would
like this simple patch to be included as a fixup for f54c013e7eef
("platform/chrome: cros_typec_vdm: Add Attention support"). Please apply
the patch if it makes sense.

One minor suggestion for the commit title:
"platform/chrome: cros_ec_typec: Fix spelling mistake" looks more clear
to me.

With that:
Reviewed-by: Tzung-Bi Shih <[email protected]>

2023-02-08 07:52:50

by Prashant Malani

[permalink] [raw]
Subject: Re: [PATCH][next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

On Tue, Feb 7, 2023 at 11:33 PM Tzung-Bi Shih <[email protected]> wrote:
>
> Hi Prashant,
>
> On Tue, Feb 07, 2023 at 09:14:43AM +0000, Colin Ian King wrote:
> > There is a spelling mistake in a dev_warn message, make it lower case
> > and fix the spelling.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> It's about time to cut for the coming merge window.

I thought there would be an rc8...

> I guess you would
> like this simple patch to be included as a fixup for f54c013e7eef
> ("platform/chrome: cros_typec_vdm: Add Attention support"). Please apply
> the patch if it makes sense.

Sure. I'll make the modification you suggest and apply this tomorrow.
Thanks for signal boosting it.

>
> One minor suggestion for the commit title:
> "platform/chrome: cros_ec_typec: Fix spelling mistake" looks more clear
> to me.
>
> With that:
> Reviewed-by: Tzung-Bi Shih <[email protected]>

Subject: Re: [PATCH][next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Prashant Malani <[email protected]>:

On Tue, 7 Feb 2023 09:14:43 +0000 you wrote:
> There is a spelling mistake in a dev_warn message, make it lower case
> and fix the spelling.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/platform/chrome/cros_ec_typec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"
https://git.kernel.org/chrome-platform/c/b0d8a67715da

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



Subject: Re: [PATCH][next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Prashant Malani <[email protected]>:

On Tue, 7 Feb 2023 09:14:43 +0000 you wrote:
> There is a spelling mistake in a dev_warn message, make it lower case
> and fix the spelling.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/platform/chrome/cros_ec_typec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"
https://git.kernel.org/chrome-platform/c/b0d8a67715da

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html