Hi Joe,
On Wed, Dec 14, 2022 at 10:15 PM Joe Wu
<[email protected]> wrote:
>
> This patch is to add extra 3 buttons: 'brightness up',
> 'brightness down' and 'leave PC(cros) mode' to support
> monitor navigation function.
nit: Please use the imperative form [1] while describing patches.
In this case, that would translate to:
"Add extra 3 buttons..."
Thanks,
-Prashant
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
Hi Prashant,
Thank you for comments. I will correct the description to be imperative mood.
BRs,
Joe
-----Original Message-----
From: Prashant Malani <[email protected]>
Sent: Friday, December 16, 2022 6:59 AM
To: Joe Wu <[email protected]>
Cc: LKML <[email protected]>; Stephen Boyd <[email protected]>; Xiang wangx <[email protected]>; [email protected]; Derek Huang <[email protected]>; Greg Kroah-Hartman <[email protected]>; Benson Leung <[email protected]>; Daisuke Nojiri <[email protected]>; Furquan Shaikh <[email protected]>; Tzung-Bi Shih <[email protected]>; [email protected]; Douglas Anderson <[email protected]>; Dustin L . Howett <[email protected]>; Dmitry Torokhov <[email protected]>; Guenter Roeck <[email protected]>; Gustavo A . R . Silva <[email protected]>; Sebastian Reichel <[email protected]>
Subject: Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function
Hi Joe,
On Wed, Dec 14, 2022 at 10:15 PM Joe Wu
<[email protected]> wrote:
>
> This patch is to add extra 3 buttons: 'brightness up', 'brightness
> down' and 'leave PC(cros) mode' to support monitor navigation
> function.
nit: Please use the imperative form [1] while describing patches.
In this case, that would translate to:
"Add extra 3 buttons..."
Thanks,
-Prashant
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
*****CONFIDENTIAL INFORMATION*****
This email is intended only for the use of the person or entity to whom it is
addressed and contains information that may be subject to and/or may be
restricted from disclosure by contract or applicable law. If you are not the
intended recipient of this email, be advised that any disclosure, copy,
distribution or use of the contents of this message is strictly prohibited.
If you are not the intended recipient of this email, please notify the sender
that you have received this in error by replying to this message. Then,
please delete it from your system. Our Privacy Policy is available here
https://www.msi.com/page/privacy-policy. Thank you.