2017-11-08 20:02:42

by Akshay Bhat

[permalink] [raw]
Subject: Re: [PATCH 3/3] rtc: rx8010: Fix for incorrect return value

On Tue, Nov 7, 2017 at 9:30 PM, Alexandre Belloni
<[email protected]> wrote:
> On 03/11/2017 at 13:32:41 -0400, Akshay Bhat wrote:
>> if (err != 2)
>> return err < 0 ? err : -EIO;
>> + err = 0;
>
> Isn't it simpler to make the function return 0 instead of err at the end?

Makes sense, fixed in v2 patch, thanks.

From 1583482995672243329@xxx Wed Nov 08 07:44:23 +0000 2017
X-GM-THRID: 1583067177371222306
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread