2017-12-02 15:39:43

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] kernel-docs.rst: update broken linuxjournal links

On Thu, 30 Nov 2017 17:47:25 +0700
Nguyễn Thái Ngọc Duy <[email protected]> wrote:

> Signed-off-by: Nguyễn Thái Ngọc Duy <[email protected]>
> ---
> Documentation/process/kernel-docs.rst | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)

So I'm reluctant to take patches without a changelog. One would help in
this case...what is broken about these links? They all work for me. For
as long as LJ links will work in general, I guess.

Thanks,

jon

> diff --git a/Documentation/process/kernel-docs.rst b/Documentation/process/kernel-docs.rst
> index b8cac85a4001..66040404ac9f 100644
> --- a/Documentation/process/kernel-docs.rst
> +++ b/Documentation/process/kernel-docs.rst
> @@ -322,7 +322,7 @@ On-line docs
> * Title: **The Linux RAID-1, 4, 5 Code**
>
> :Author: Ingo Molnar, Gadi Oxman and Miguel de Icaza.
> - :URL: http://www.linuxjournal.com/article.php?sid=2391
> + :URL: http://www.linuxjournal.com/article/2391
> :Date: 1997
> :Keywords: RAID, MD driver.
> :Description: Linux Journal Kernel Korner article. Here is its
> @@ -346,7 +346,7 @@ On-line docs
> * Title: **Dynamic Kernels: Modularized Device Drivers**
>
> :Author: Alessandro Rubini.
> - :URL: http://www.linuxjournal.com/article.php?sid=1219
> + :URL: http://www.linuxjournal.com/article/1219
> :Date: 1996
> :Keywords: device driver, module, loading/unloading modules,
> allocating resources.
> @@ -361,7 +361,7 @@ On-line docs
> * Title: **Dynamic Kernels: Discovery**
>
> :Author: Alessandro Rubini.
> - :URL: http://www.linuxjournal.com/article.php?sid=1220
> + :URL: http://www.linuxjournal.com/article/1220
> :Date: 1996
> :Keywords: character driver, init_module, clean_up module,
> autodetection, mayor number, minor number, file operations,
> @@ -375,7 +375,7 @@ On-line docs
> * Title: **The Devil's in the Details**
>
> :Author: Georg v. Zezschwitz and Alessandro Rubini.
> - :URL: http://www.linuxjournal.com/article.php?sid=1221
> + :URL: http://www.linuxjournal.com/article/1221
> :Date: 1996
> :Keywords: read(), write(), select(), ioctl(), blocking/non
> blocking mode, interrupt handler.
> @@ -387,7 +387,7 @@ On-line docs
> * Title: **Dissecting Interrupts and Browsing DMA**
>
> :Author: Alessandro Rubini and Georg v. Zezschwitz.
> - :URL: http://www.linuxjournal.com/article.php?sid=1222
> + :URL: http://www.linuxjournal.com/article/1222
> :Date: 1996
> :Keywords: interrupts, irqs, DMA, bottom halves, task queues.
> :Description: Linux Journal Kernel Korner article. Here is its
> @@ -403,7 +403,7 @@ On-line docs
> * Title: **Device Drivers Concluded**
>
> :Author: Georg v. Zezschwitz.
> - :URL: http://www.linuxjournal.com/article.php?sid=1287
> + :URL: http://www.linuxjournal.com/article/1287
> :Date: 1996
> :Keywords: address spaces, pages, pagination, page management,
> demand loading, swapping, memory protection, memory mapping, mmap,
> @@ -417,7 +417,7 @@ On-line docs
> * Title: **Network Buffers And Memory Management**
>
> :Author: Alan Cox.
> - :URL: http://www.linuxjournal.com/article.php?sid=1312
> + :URL: http://www.linuxjournal.com/article/1312
> :Date: 1996
> :Keywords: sk_buffs, network devices, protocol/link layer
> variables, network devices flags, transmit, receive,


2017-12-04 09:07:28

by Duy Nguyen

[permalink] [raw]
Subject: Re: [PATCH] kernel-docs.rst: update broken linuxjournal links

On Sat, Dec 2, 2017 at 10:39 PM, Jonathan Corbet <[email protected]> wrote:
> On Thu, 30 Nov 2017 17:47:25 +0700
> Nguyễn Thái Ngọc Duy <[email protected]> wrote:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <[email protected]>
>> ---
>> Documentation/process/kernel-docs.rst | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> So I'm reluctant to take patches without a changelog. One would help in
> this case...what is broken about these links? They all work for me. For
> as long as LJ links will work in general, I guess.

Hmm.. it was broken for me and I had to resort back to archive.org
before realizing that the content was probably still there under a
different url. Anyway the old urls do work for me now. Please ignore
the patch.