2021-01-18 21:13:52

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters

On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote:
> From: Bongsu Jeon <[email protected]>
>
> Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0
> but there is no parameters in NCI1.x.
>
> Signed-off-by: Bongsu Jeon <[email protected]>

What's the Fixes tag for this change?


2021-01-18 21:26:24

by Bongsu Jeon

[permalink] [raw]
Subject: Re: [PATCH net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters

On Tue, Jan 19, 2021 at 6:01 AM Jakub Kicinski <[email protected]> wrote:
>
> On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote:
> > From: Bongsu Jeon <[email protected]>
> >
> > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0
> > but there is no parameters in NCI1.x.
> >
> > Signed-off-by: Bongsu Jeon <[email protected]>
>
> What's the Fixes tag for this change?
Sorry to miss the Fixes tag.
This is the Fixes tag ( Fixes: bcd684aace34 ("net/nfc/nci: Support NCI
2.x initial sequence") )
Could I resend this patch after adding that tag?

2021-01-19 05:23:16

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters

On Tue, 19 Jan 2021 06:19:23 +0900 Bongsu Jeon wrote:
> On Tue, Jan 19, 2021 at 6:01 AM Jakub Kicinski <[email protected]> wrote:
> >
> > On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote:
> > > From: Bongsu Jeon <[email protected]>
> > >
> > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0
> > > but there is no parameters in NCI1.x.
> > >
> > > Signed-off-by: Bongsu Jeon <[email protected]>
> >
> > What's the Fixes tag for this change?
> Sorry to miss the Fixes tag.
> This is the Fixes tag ( Fixes: bcd684aace34 ("net/nfc/nci: Support NCI
> 2.x initial sequence") )
> Could I resend this patch after adding that tag?

It's fine no need to repost, I can add the tag when applying the patch,
let's wait for reviews. Let me just place it on a line of its own,
patchwork is supposed to pick that up automatically:

Fixes: bcd684aace34 ("net/nfc/nci: Support NCI 2.x initial sequence")