In suspend sequence stop_rx will be performed only if implementation for
start_rx callback is present.
Set qcom_geni_serial_start_rx as callback for start_rx so that stop_rx is
performed.
Signed-off-by: Vijaya Krishna Nivarthi <[email protected]>
---
drivers/tty/serial/qcom_geni_serial.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 4733a23..f8f9506 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -1306,6 +1306,7 @@ static const struct uart_ops qcom_geni_console_pops = {
.stop_tx = qcom_geni_serial_stop_tx,
.start_tx = qcom_geni_serial_start_tx,
.stop_rx = qcom_geni_serial_stop_rx,
+ .start_rx = qcom_geni_serial_start_rx,
.set_termios = qcom_geni_serial_set_termios,
.startup = qcom_geni_serial_startup,
.request_port = qcom_geni_serial_request_port,
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.
Hi,
On Tue, Jun 7, 2022 at 11:53 AM Vijaya Krishna Nivarthi
<[email protected]> wrote:
>
> In suspend sequence stop_rx will be performed only if implementation for
> start_rx callback is present.
>
> Set qcom_geni_serial_start_rx as callback for start_rx so that stop_rx is
> performed.
>
> Signed-off-by: Vijaya Krishna Nivarthi <[email protected]>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 1 +
> 1 file changed, 1 insertion(+)
I think you also want a Fixes tag here, right? ...because if only the
first patch is taken then it can actually regress Qualcomm devices.
Thus:
Fixes: c9d2325cdb92 ("serial: core: Do stop_rx in suspend path for
console if console_suspend is disabled")
Reviewed-by: Douglas Anderson <[email protected]>