On Mon, Apr 22, 2024 at 05:03:04PM +0800, Cong Yang wrote:
> In V1, discussed with Doug and Linus [1], we need break out as separate
> driver for the himax83102-j02 controller. So add new documentation for
> "starry,himax83102-j02" panel.
>
> [1]: https://lore.kernel.org/all/CACRpkdbzYZAS0=zBQJUC4CB2wj4s1h6n6aSAZQvdMV95r3zRUw@mail.gmail.com
Please summarize this in the commit message rather than referring to a
link to understand "why" you doing this.
>
> Signed-off-by: Cong Yang <[email protected]>
> ---
> .../display/panel/boe,tv101wum-nl6.yaml | 2 -
> .../bindings/display/panel/himax,hx83102.yaml | 73 +++++++++++++++++++
> 2 files changed, 73 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
> index 906ef62709b8..53fb35f5c9de 100644
> --- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
> @@ -32,8 +32,6 @@ properties:
> - innolux,hj110iz-01a
> # STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel
> - starry,2081101qfh032011-53g
> - # STARRY himax83102-j02 10.51" WUXGA TFT LCD panel
> - - starry,himax83102-j02
> # STARRY ili9882t 10.51" WUXGA TFT LCD panel
> - starry,ili9882t
>
> diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
> new file mode 100644
> index 000000000000..2e0cd6998ba8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/himax,hx83102.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Himax HX83102 MIPI-DSI LCD panel controller
> +
> +maintainers:
> + - Cong Yang <[email protected]>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + # STARRY himax83102-j02 10.51" WUXGA TFT LCD panel
> + - starry,himax83102-j02
> +
> + reg:
> + description: the virtual channel number of a DSI peripheral
> +
> + enable-gpios:
> + description: a GPIO spec for the enable pin
> +
> + pp1800-supply:
> + description: core voltage supply
> +
> + avdd-supply:
> + description: phandle of the regulator that provides positive voltage
> +
> + avee-supply:
> + description: phandle of the regulator that provides negative voltage
> +
> + backlight:
> + description: phandle of the backlight device attached to the panel
> +
> + port: true
> + rotation: true
> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - pp1800-supply
> + - avdd-supply
> + - avee-supply
> +
> +additionalProperties: false
Perhaps 'unevaluatedProperties' instead. Don't you want to support
standard properties such as width-mm/height-mm?
> +
> +examples:
> + - |
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel@0 {
> + compatible = "starry,himax83102-j02";
> + reg = <0>;
> + enable-gpios = <&pio 45 0>;
> + avdd-supply = <&ppvarn_lcd>;
> + avee-supply = <&ppvarp_lcd>;
> + pp1800-supply = <&pp1800_lcd>;
> + backlight = <&backlight_lcd0>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&dsi_out>;
> + };
> + };
> + };
> + };
> +
> +...
> --
> 2.25.1
>
Hi,
On Mon, Apr 22, 2024 at 8:14 AM Rob Herring <[email protected]> wrote:
>
> > +additionalProperties: false
>
> Perhaps 'unevaluatedProperties' instead. Don't you want to support
> standard properties such as width-mm/height-mm?
For at least those two properties, it looks like the answer is "no".
From reading the Linux driver it appears that physical width/height is
implied by the compatible string. Unless there are other properties we
think we need, maybe it's fine to keep "additionalProperties" ?
-Doug