2013-03-15 16:26:05

by Naveen Krishna Chatradhi

[permalink] [raw]
Subject: [PATCH 1/2] iio: adc: Kconfig: exynos_adc depends on CONFIG_OF

As the exynos_adc driver only supports device tree registration.
Making driver depend on CONFIG_OF solves possible errors during probe.

Signed-off-by: Naveen Krishna Chatradhi <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Cc: Doug Anderson <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>
---
Discussion thread for this patch can be found at
http://www.gossamer-threads.com/lists/linux/kernel/1693284?page=last

drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index a40d3c2..9c45c0f 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -105,6 +105,7 @@ config AT91_ADC

config EXYNOS_ADC
bool "Exynos ADC driver support"
+ depends on OF
help
Core support for the ADC block found in the Samsung EXYNOS series
of SoCs for drivers such as the touchscreen and hwmon to use to share
--
1.7.9.5


2013-03-15 18:09:26

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH 1/2] iio: adc: Kconfig: exynos_adc depends on CONFIG_OF

Naveen,

On Fri, Mar 15, 2013 at 9:23 AM, Naveen Krishna Chatradhi
<[email protected]> wrote:
> As the exynos_adc driver only supports device tree registration.
> Making driver depend on CONFIG_OF solves possible errors during probe.
>
> Signed-off-by: Naveen Krishna Chatradhi <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Cc: Doug Anderson <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>
> ---
> Discussion thread for this patch can be found at
> http://www.gossamer-threads.com/lists/linux/kernel/1693284?page=last
>
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Doug Anderson <[email protected]>

2013-03-17 22:42:31

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 1/2] iio: adc: Kconfig: exynos_adc depends on CONFIG_OF

On 03/15/2013 06:09 PM, Doug Anderson wrote:
> Naveen,
>
> On Fri, Mar 15, 2013 at 9:23 AM, Naveen Krishna Chatradhi
> <[email protected]> wrote:
>> As the exynos_adc driver only supports device tree registration.
>> Making driver depend on CONFIG_OF solves possible errors during probe.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <[email protected]>
>> Reported-by: Dan Carpenter <[email protected]>
>> Cc: Doug Anderson <[email protected]>
>> Cc: Lars-Peter Clausen <[email protected]>
>> ---
>> Discussion thread for this patch can be found at
>> http://www.gossamer-threads.com/lists/linux/kernel/1693284?page=last
>>
>> drivers/iio/adc/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>
> Reviewed-by: Doug Anderson <[email protected]>
Applied to togreg branch of iio.git, thanks,

> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>