2015-04-07 13:03:51

by Javier Martinez Canillas

Subject: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards

The Marvell mwifiex driver prevents the system to enter into a suspend
state if the card power is not preserved during a suspend/resume cycle.

So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
and Exynos5420 Peach Pit Chromebooks.

Add the keep-power-in-suspend Power Management property to the SDIO/MMC
node so the mwifiex suspend handler doesn't fail and the system is able
to enter into a suspend state.

Signed-off-by: Javier Martinez Canillas <[email protected]>
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
2 files changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 0788d08fb43e..146e71118a72 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -711,6 +711,7 @@
num-slots = <1>;
broken-cd;
cap-sdio-irq;
+ keep-power-in-suspend;
card-detect-delay = <200>;
clock-frequency = <400000000>;
samsung,dw-mshc-ciu-div = <1>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 412f41d62686..02eb8b15374f 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -674,6 +674,7 @@
num-slots = <1>;
broken-cd;
cap-sdio-irq;
+ keep-power-in-suspend;
card-detect-delay = <200>;
clock-frequency = <400000000>;
samsung,dw-mshc-ciu-div = <1>;
--
2.1.4

2015-04-07 15:09:26

by Doug Anderson

Subject: Re: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards

Javier,

On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
<[email protected]> wrote:
> The Marvell mwifiex driver prevents the system to enter into a suspend
> state if the card power is not preserved during a suspend/resume cycle.
>
> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
> and Exynos5420 Peach Pit Chromebooks.
>
> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
> node so the mwifiex suspend handler doesn't fail and the system is able
> to enter into a suspend state.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
> ---
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
> 2 files changed, 2 insertions(+)

Reviewed-by: Doug Anderson <[email protected]>

2015-04-15 08:07:53

by Javier Martinez Canillas

Subject: Re: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards

Hello Kukjin,

On 04/07/2015 05:09 PM, Doug Anderson wrote:
> Javier,
>
> On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
> <[email protected]> wrote:
>> The Marvell mwifiex driver prevents the system to enter into a suspend
>> state if the card power is not preserved during a suspend/resume cycle.
>>
>> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
>> and Exynos5420 Peach Pit Chromebooks.
>>
>> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
>> node so the mwifiex suspend handler doesn't fail and the system is able
>> to enter into a suspend state.
>>
>> Signed-off-by: Javier Martinez Canillas <[email protected]>
>> ---
>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
>> 2 files changed, 2 insertions(+)
>
> Reviewed-by: Doug Anderson <[email protected]>
>

Any comments on this patch?

Best regards,
Javier

2015-04-30 00:41:46

by Javier Martinez Canillas

Subject: Re: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards

Hello Kukjin,

On 04/15/2015 10:07 AM, Javier Martinez Canillas wrote:
>
> On 04/07/2015 05:09 PM, Doug Anderson wrote:
>> Javier,
>>
>> On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
>> <[email protected]> wrote:
>>> The Marvell mwifiex driver prevents the system to enter into a suspend
>>> state if the card power is not preserved during a suspend/resume cycle.
>>>
>>> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
>>> and Exynos5420 Peach Pit Chromebooks.
>>>
>>> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
>>> node so the mwifiex suspend handler doesn't fail and the system is able
>>> to enter into a suspend state.
>>>
>>> Signed-off-by: Javier Martinez Canillas <[email protected]>
>>> ---
>>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
>>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
>>> 2 files changed, 2 insertions(+)
>>
>> Reviewed-by: Doug Anderson <[email protected]>
>>
>
> Any comments on this patch?
>
> Best regards,
> Javier
>

Gentle reminder about this patch.

Best regards,
Javier