2024-06-12 13:37:14

by Tejas Vipin

Subject: [PATCH 1/2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

mipi_dsi_msleep should be modified to accept ctx as a pointer and the
function call should be adjusted accordingly.

Fixes: a2ab7cb169da3 ("drm/panel: himax-hx83102: use wrapped MIPI DCS functions")
Signed-off-by: Tejas Vipin <[email protected]>
---
drivers/gpu/drm/panel/panel-himax-hx83102.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-himax-hx83102.c b/drivers/gpu/drm/panel/panel-himax-hx83102.c
index 6009a3fe1b8f..6e4b7e4644ce 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx83102.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx83102.c
@@ -286,7 +286,7 @@ static int boe_nv110wum_init(struct hx83102 *ctx)
mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83102_SETBANK, 0x00);
hx83102_enable_extended_cmds(&dsi_ctx, false);

- mipi_dsi_msleep(dsi_ctx, 50);
+ mipi_dsi_msleep(&dsi_ctx, 50);

return dsi_ctx.accum_err;
};
@@ -391,7 +391,7 @@ static int ivo_t109nw41_init(struct hx83102 *ctx)
mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83102_SETBANK, 0x00);
hx83102_enable_extended_cmds(&dsi_ctx, false);

- mipi_dsi_msleep(dsi_ctx, 60);
+ mipi_dsi_msleep(&dsi_ctx, 60);

return dsi_ctx.accum_err;
};
@@ -538,7 +538,7 @@ static int hx83102_prepare(struct drm_panel *panel)
dsi_ctx.accum_err = ctx->desc->init(ctx);

mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
- mipi_dsi_msleep(dsi_ctx, 120);
+ mipi_dsi_msleep(&dsi_ctx, 120);
mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
if (dsi_ctx.accum_err)
goto poweroff;
--
2.45.2

2024-06-12 14:03:51

by Doug Anderson

Subject: Re: [PATCH 1/2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

Hi,

On Wed, Jun 12, 2024 at 6:37 AM Tejas Vipin <[email protected]> wrote:
>
> mipi_dsi_msleep should be modified to accept ctx as a pointer and the
> function call should be adjusted accordingly.
>
> Fixes: a2ab7cb169da3 ("drm/panel: himax-hx83102: use wrapped MIPI DCS functions")
> Signed-off-by: Tejas Vipin <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-himax-hx83102.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Thanks!

Reviewed-by: Douglas Anderson <[email protected]>