2024-05-01 05:13:50

by Sui Jingfeng

Subject: [PATCH v2] drm/debugfs: Drop conditionals around of_node pointers

Having conditional around the of_node pointer of the drm_bridge structure
is not necessary anymore, since drm_bridge structure always has the of_node
member since the commit d8dfccde2709 ("drm/bridge: Drop conditionals around
of_node pointers").

So drop the conditional, please also note that this patch is following the
convention used by driver core, see commit c9e358dfc4a8 ("driver-core:
remove conditionals around devicetree pointers").

Reviewed-by: Dmitry Baryshkov <[email protected]>
Signed-off-by: Sui Jingfeng <[email protected]>
---
v2: Update commit message
---
drivers/gpu/drm/drm_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index 08fcefd804bc..28a471fe4bc8 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -597,10 +597,10 @@ static int bridges_show(struct seq_file *m, void *data)
drm_printf(&p, "\ttype: [%d] %s\n",
bridge->type,
drm_get_connector_type_name(bridge->type));
-#ifdef CONFIG_OF
+
if (bridge->of_node)
drm_printf(&p, "\tOF: %pOFfc\n", bridge->of_node);
-#endif
+
drm_printf(&p, "\tops: [0x%x]", bridge->ops);
if (bridge->ops & DRM_BRIDGE_OP_DETECT)
drm_puts(&p, " detect");
--
2.34.1

2024-05-01 16:18:18

by Doug Anderson

Subject: Re: [PATCH v2] drm/debugfs: Drop conditionals around of_node pointers

Hi,

On Tue, Apr 30, 2024 at 10:13 PM Sui Jingfeng <[email protected]> wrote:
>
> Having conditional around the of_node pointer of the drm_bridge structure
> is not necessary anymore, since drm_bridge structure always has the of_node
> member since the commit d8dfccde2709 ("drm/bridge: Drop conditionals around
> of_node pointers").
>
> So drop the conditional, please also note that this patch is following the
> convention used by driver core, see commit c9e358dfc4a8 ("driver-core:
> remove conditionals around devicetree pointers").
>
> Reviewed-by: Dmitry Baryshkov <[email protected]>
> Signed-off-by: Sui Jingfeng <[email protected]>
> ---
> v2: Update commit message
> ---
> drivers/gpu/drm/drm_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Pushed to drm-misc-next:

235e60653f8d drm/debugfs: Drop conditionals around of_node pointers

-Doug