2022-01-04 01:24:22

by Zhijian Li (Fujitsu)

Subject: [PATCH v2] RDMA/rxe: Get rid of redundant plus

From: Li Zhijian <[email protected]>

Get rid of the duplicate plus in a line to be consistent with others.

Signed-off-by: Li Zhijian <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_opcode.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
index 3ef5a10a6efd..79122eeb4d82 100644
--- a/drivers/infiniband/sw/rxe/rxe_opcode.c
+++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
@@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
[RXE_ATMETH] = RXE_BTH_BYTES
+ RXE_RDETH_BYTES
+ RXE_DETH_BYTES,
- [RXE_PAYLOAD] = RXE_BTH_BYTES +
+ [RXE_PAYLOAD] = RXE_BTH_BYTES
+ RXE_ATMETH_BYTES
- + RXE_DETH_BYTES +
+ + RXE_DETH_BYTES
+ RXE_RDETH_BYTES,
}
},
@@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
[RXE_ATMETH] = RXE_BTH_BYTES
+ RXE_RDETH_BYTES
+ RXE_DETH_BYTES,
- [RXE_PAYLOAD] = RXE_BTH_BYTES +
+ [RXE_PAYLOAD] = RXE_BTH_BYTES
+ RXE_ATMETH_BYTES
- + RXE_DETH_BYTES +
+ + RXE_DETH_BYTES
+ RXE_RDETH_BYTES,
}
},
--
2.33.0

2022-01-04 02:46:43

by Zhu Yanjun

Subject: Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus

On Tue, Jan 4, 2022 at 9:25 AM Li Zhijian <[email protected]> wrote:
>
> From: Li Zhijian <[email protected]>
>
> Get rid of the duplicate plus in a line to be consistent with others.
>
> Signed-off-by: Li Zhijian <[email protected]>

Reviewed-by: Zhu Yanjun <[email protected]>

Zhu Yanjun

> ---
> drivers/infiniband/sw/rxe/rxe_opcode.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
> index 3ef5a10a6efd..79122eeb4d82 100644
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
> --
> 2.33.0
>
>
>

2022-01-04 07:54:11

by Christoph Hellwig

Subject: Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus

On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },

Please fix this up to always have the + on the continuing line which
is the normal kernel style.

2022-01-04 10:38:24

by Zhijian Li (Fujitsu)

Subject: Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus

On 04/01/2022 15:54, Christoph Hellwig wrote:
> On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
>> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
>> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>> [RXE_ATMETH] = RXE_BTH_BYTES
>> + RXE_RDETH_BYTES
>> + RXE_DETH_BYTES,
>> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
>> + [RXE_PAYLOAD] = RXE_BTH_BYTES
>> + RXE_ATMETH_BYTES
>> - + RXE_DETH_BYTES +
>> + + RXE_DETH_BYTES
>> + RXE_RDETH_BYTES,
>> }
>> },
>> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>> [RXE_ATMETH] = RXE_BTH_BYTES
>> + RXE_RDETH_BYTES
>> + RXE_DETH_BYTES,
>> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
>> + [RXE_PAYLOAD] = RXE_BTH_BYTES
>> + RXE_ATMETH_BYTES
>> - + RXE_DETH_BYTES +
>> + + RXE_DETH_BYTES
>> + RXE_RDETH_BYTES,
>> }
>> },
> Please fix this up to always have the + on the continuing line which
> is the normal kernel style.
I'm so glad to hear that, i will also update the existing unconventional style in this file.