2022-08-11 02:59:46

by Dongliang Mu

Subject: [PATCH 2/2] USB: ncevibrator: simplify tv_probe

From: Dongliang Mu <[email protected]>

The function tv_probe does not need to invoke kfree when the
allocation fails. So let's simplify the code of tv_probe.

Signed-off-by: Dongliang Mu <[email protected]>
---
drivers/usb/misc/trancevibrator.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c
index 55cb63652eda..30d4d774d448 100644
--- a/drivers/usb/misc/trancevibrator.c
+++ b/drivers/usb/misc/trancevibrator.c
@@ -84,22 +84,15 @@ static int tv_probe(struct usb_interface *interface,
{
struct usb_device *udev = interface_to_usbdev(interface);
struct trancevibrator *dev;
- int retval;

dev = kzalloc(sizeof(struct trancevibrator), GFP_KERNEL);
- if (!dev) {
- retval = -ENOMEM;
- goto error;
- }
+ if (!dev)
+ return -ENOMEM;

dev->udev = usb_get_dev(udev);
usb_set_intfdata(interface, dev);

return 0;
-
-error:
- kfree(dev);
- return retval;
}

static void tv_disconnect(struct usb_interface *interface)
--
2.35.1

2022-08-11 09:51:02

by Sergey Shtylyov

Subject: Re: [PATCH 2/2] USB: ncevibrator: simplify tv_probe

Hello!

Your subject is broken now. :-)

MBR, Sergey

2022-08-11 10:12:14

by Dongliang Mu

Subject: Re: [PATCH 2/2] USB: ncevibrator: simplify tv_probe

On Thu, Aug 11, 2022 at 4:34 PM Sergey Shtylyov <[email protected]> wrote:
>
> Hello!
>
> Your subject is broken now. :-)

Yes, thanks for your reminder. Will send a v2 patch.

>
> MBR, Sergey