Hi Herbert,
your commit 149a39717dcc ("crypto: aead - Add type-safe geniv
init/exit helpers") has shown up in Linux next (i.e., next-20150818)
adding the following lines of code to crypto/Kconfig:
@@ -150,12 +152,15 @@ config CRYPTO_GF128MUL
[...]
+config CRYPTO_NULL2
+ select CRYPTO_ALGAPI2
+ select CRYPTO_BLKCIPHER2
+ select CRYPTO_HASH2
+
There are two problems with the option above: (1) It does not have a
type, (2) it selects other options without being a tristate/boolean,
see below:
scripts/kconfig/mconf Kconfig
crypto/Kconfig:159:warning: config symbol defined without type
crypto/Kconfig:160:warning: config symbol 'CRYPTO_NULL2' uses select,
but is not boolean or tristate
crypto/Kconfig:161:warning: config symbol 'CRYPTO_NULL2' uses select,
but is not boolean or tristate
crypto/Kconfig:162:warning: config symbol 'CRYPTO_NULL2' uses select,
but is not boolean or tristate
If you want to, I can send a trivial patch making it a boolean without prompt.
I detected this issue with undertaker-checkpatch (undertaker.cs.fau.de).
Kind regards,
Valentin
On Wed, Aug 19, 2015 at 09:49:37AM +0200, Valentin Rothberg wrote:
>
> your commit 149a39717dcc ("crypto: aead - Add type-safe geniv
> init/exit helpers") has shown up in Linux next (i.e., next-20150818)
> adding the following lines of code to crypto/Kconfig:
Thanks but this was fixed two days ago.
Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, Aug 19, 2015 at 9:52 AM, Herbert Xu <[email protected]> wrote:
> On Wed, Aug 19, 2015 at 09:49:37AM +0200, Valentin Rothberg wrote:
>>
>> your commit 149a39717dcc ("crypto: aead - Add type-safe geniv
>> init/exit helpers") has shown up in Linux next (i.e., next-20150818)
>> adding the following lines of code to crypto/Kconfig:
>
> Thanks but this was fixed two days ago.
Oups! Sorry for the noise. I obviously missed resetting my HEAD
before checking the report.
Kind regards,
Valentin
> Cheers,
> --
> Email: Herbert Xu <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt