2016-10-04 05:59:56

by Valentin Rothberg

[permalink] [raw]
Subject: samples: blackfin: dead config options

Hi Shua,

your commit c6d2995da540 ("samples: move blackfin gptimers-example
from Documentation") has popped up in today's linux-next.
scripts/checkkconfigsymbols.py complained about two issues.

The refactoring from build rules to Kconfig preserved the 'CONFIG_'
prefix (i.e., depends on CONFIG_BLACKFIN && CONFIG_BFIN_GPTIMERS...),
rendering SAMPLE_BLACKFIN_GPTIMERS to be dead.

The patch also removes the option BUILD_DOCSRC, which has one leftover
dependency in drivers/media/v4l2-core/Kconfig (VIDEO_PCI_SKELETON).

Are there patches queued somewhere to address the upper issues?

Best regards,
Valentin


2016-10-04 14:45:18

by Shuah Khan

[permalink] [raw]
Subject: Re: samples: blackfin: dead config options

On 10/03/2016 11:59 PM, Valentin Rothberg wrote:
> Hi Shua,
>
> your commit c6d2995da540 ("samples: move blackfin gptimers-example
> from Documentation") has popped up in today's linux-next.
> scripts/checkkconfigsymbols.py complained about two issues.
>
> The refactoring from build rules to Kconfig preserved the 'CONFIG_'
> prefix (i.e., depends on CONFIG_BLACKFIN && CONFIG_BFIN_GPTIMERS...),
> rendering SAMPLE_BLACKFIN_GPTIMERS to be dead.
>
> The patch also removes the option BUILD_DOCSRC, which has one leftover
> dependency in drivers/media/v4l2-core/Kconfig (VIDEO_PCI_SKELETON).
>
> Are there patches queued somewhere to address the upper issues?
>
> Best regards,
> Valentin
>

Hi Valentin,

I am looking at these problems and I don't have fixes yet. I will get
the fixes soon or pull it out of linux-next in a day r two.

thanks,
-- Shuah

2016-10-04 15:18:02

by Paul Gortmaker

[permalink] [raw]
Subject: Re: samples: blackfin: dead config options

On Tue, Oct 4, 2016 at 10:45 AM, Shuah Khan <[email protected]> wrote:
> On 10/03/2016 11:59 PM, Valentin Rothberg wrote:
>> Hi Shua,
>>
>> your commit c6d2995da540 ("samples: move blackfin gptimers-example
>> from Documentation") has popped up in today's linux-next.
>> scripts/checkkconfigsymbols.py complained about two issues.
>>
>> The refactoring from build rules to Kconfig preserved the 'CONFIG_'
>> prefix (i.e., depends on CONFIG_BLACKFIN && CONFIG_BFIN_GPTIMERS...),
>> rendering SAMPLE_BLACKFIN_GPTIMERS to be dead.
>>
>> The patch also removes the option BUILD_DOCSRC, which has one leftover
>> dependency in drivers/media/v4l2-core/Kconfig (VIDEO_PCI_SKELETON).
>>
>> Are there patches queued somewhere to address the upper issues?
>>
>> Best regards,
>> Valentin
>>
>
> Hi Valentin,
>
> I am looking at these problems and I don't have fixes yet. I will get
> the fixes soon or pull it out of linux-next in a day r two.

In addition to what Valentin reports, it also breaks "distclean".

$ make distclean
scripts/Makefile.clean:14: Documentation/Makefile: No such file or directory
make[1]: *** No rule to make target 'Documentation/Makefile'. Stop.
Makefile:1278: recipe for target '_clean_Documentation' failed
make: *** [_clean_Documentation] Error 2

Paul.
--

>
> thanks,
> -- Shuah