2015-07-31 18:43:07

by Valentin Rothberg

Subject: mips: MT: ptrace.c: undefined MIPS_MT_SMTC

Hi Ralf,

your commit 23c59ee7e541 ("MIPS: Add uprobes support.") is in today's
linux-next tree (i.e., next-20150731) and it adds the following lines
of code to arch/mips/kernel/ptrace.c:

+#ifdef CONFIG_MIPS_MT_SMTC
+ REG_OFFSET_NAME(c0_tcstatus, cp0_tcstatus),
+#endif

The Kconfig option MIPS_MT_SMTC has been removed by commit
b633648c5ad3 ("MIPS: MT: Remove SMTC support") so that the upper
#ifdef block cannot be compiled. Is this intentional or can the block
be removed or should the option be substituted to something else?

I detected the issue with scripts/checkkconfigsymbols.py.

Kind regards,
Valentin

2015-08-21 13:22:19

by Valentin Rothberg

Subject: Re: mips: MT: ptrace.c: undefined MIPS_MT_SMTC

On Fri, Jul 31, 2015 at 8:42 PM, Valentin Rothberg
<[email protected]> wrote:
> Hi Ralf,
>
> your commit 23c59ee7e541 ("MIPS: Add uprobes support.") is in today's
> linux-next tree (i.e., next-20150731) and it adds the following lines
> of code to arch/mips/kernel/ptrace.c:
>
> +#ifdef CONFIG_MIPS_MT_SMTC
> + REG_OFFSET_NAME(c0_tcstatus, cp0_tcstatus),
> +#endif
>
> The Kconfig option MIPS_MT_SMTC has been removed by commit
> b633648c5ad3 ("MIPS: MT: Remove SMTC support") so that the upper
> #ifdef block cannot be compiled. Is this intentional or can the block
> be removed or should the option be substituted to something else?
>
> I detected the issue with scripts/checkkconfigsymbols.py.
>
> Kind regards,
> Valentin

Ping.