2015-05-14 11:37:38

by Valentin Rothberg

[permalink] [raw]
Subject: staging: remove i2o subsystem: some leftovers

Hi Greg,

your commit 4a72a7af462d ("staging: remove i2o subsystem") is in
today's linux-next tree (i.e., next-20150514) and it removes the
menuconfig I2O, but leaves the following line untouched:

drivers/Makefile:101:obj-$(CONFIG_I2O) += message/

Can this line and the folder be removed or should it depend on another option?

I detected this issue with scripts/checkkconfigsymbols.py by diffing
yesterday's and today's linux-next tree.

Kind regards,
Valentin


2015-05-14 12:54:30

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: staging: remove i2o subsystem: some leftovers

On Thu, May 14, 2015 at 01:37:04PM +0200, Valentin Rothberg wrote:
> Hi Greg,
>
> your commit 4a72a7af462d ("staging: remove i2o subsystem") is in
> today's linux-next tree (i.e., next-20150514) and it removes the
> menuconfig I2O, but leaves the following line untouched:
>
> drivers/Makefile:101:obj-$(CONFIG_I2O) += message/
>
> Can this line and the folder be removed or should it depend on another option?

The folder can't be removed (other things are in there), but this line
can. Can you send me a patch removing it so that you get the correct
credit for finding this? :)

thanks,

greg k-h

2015-05-14 12:58:47

by Valentin Rothberg

[permalink] [raw]
Subject: Re: staging: remove i2o subsystem: some leftovers

Hi Greg,

On Thu, May 14, 2015 at 2:54 PM, Greg KH <[email protected]> wrote:
> On Thu, May 14, 2015 at 01:37:04PM +0200, Valentin Rothberg wrote:
>> Hi Greg,
>>
>> your commit 4a72a7af462d ("staging: remove i2o subsystem") is in
>> today's linux-next tree (i.e., next-20150514) and it removes the
>> menuconfig I2O, but leaves the following line untouched:
>>
>> drivers/Makefile:101:obj-$(CONFIG_I2O) += message/
>>
>> Can this line and the folder be removed or should it depend on another option?
>
> The folder can't be removed (other things are in there), but this line
> can. Can you send me a patch removing it so that you get the correct
> credit for finding this? :)

Sure. I will prepare a patch that removes this line.

Kind regards,
Valentin

> thanks,
>
> greg k-h