2015-04-02 09:10:19

by Valentin Rothberg

[permalink] [raw]
Subject: memory: jz4780-nemc: Dependency on undefined Kconfig option

Hi Alex,

your commit ("memory: jz4780-nemc: driver for the NEMC on JZ4780
SoCs") sets MACH_JZ4780 as Kconfig dependency for the JZ4780_NEMC
driver.

+config JZ4780_NEMC
[...]
+ depends on MACH_JZ4780

MACH_JZ4780 is not defined in Kconfig, so that JZ4780_NEMC is always
false and the driver cannot be compiled.

Is there a patch queued somewhere that adds the missing Kconfig option?

I detected this issue with scripts/checkkconfigsymbols.py by diffing
yesterday's and today's linux-next tree.

Kind regards,
Valentin


Subject: Re: memory: jz4780-nemc: Dependency on undefined Kconfig option

Hi Valentin,

MACH_JZ4780 will definitely be added via arch/mips

But the patch series for core jz4780 SOC support still needs a bit of refresh/refining.

For reference, see

http://www.spinics.net/lists/mips/msg55258.html
https://github.com/torvalds/linux/compare/master...paulburton:wip-ci20-v4.0

I have a feeling this will come up with the dma/i2c drivers as well.

Hope that clears the confusion.

Regards,
ZubairLK

On 02/04/15 10:09, Valentin Rothberg wrote:
> Hi Alex,
>
> your commit ("memory: jz4780-nemc: driver for the NEMC on JZ4780
> SoCs") sets MACH_JZ4780 as Kconfig dependency for the JZ4780_NEMC
> driver.
>
> +config JZ4780_NEMC
> [...]
> + depends on MACH_JZ4780
>
> MACH_JZ4780 is not defined in Kconfig, so that JZ4780_NEMC is always
> false and the driver cannot be compiled.
>
> Is there a patch queued somewhere that adds the missing Kconfig option?
>
> I detected this issue with scripts/checkkconfigsymbols.py by diffing
> yesterday's and today's linux-next tree.
>
> Kind regards,
> Valentin
>

2015-04-02 09:22:29

by Valentin Rothberg

[permalink] [raw]
Subject: Re: memory: jz4780-nemc: Dependency on undefined Kconfig option

Hi Zubair,

thanks for your answer and the references.

Kind regards,
Valentin

On Thu, Apr 2, 2015 at 11:19 AM, Zubair Lutfullah Kakakhel
<[email protected]> wrote:
> Hi Valentin,
>
> MACH_JZ4780 will definitely be added via arch/mips
>
> But the patch series for core jz4780 SOC support still needs a bit of refresh/refining.
>
> For reference, see
>
> http://www.spinics.net/lists/mips/msg55258.html
> https://github.com/torvalds/linux/compare/master...paulburton:wip-ci20-v4.0
>
> I have a feeling this will come up with the dma/i2c drivers as well.
>
> Hope that clears the confusion.
>
> Regards,
> ZubairLK
>
> On 02/04/15 10:09, Valentin Rothberg wrote:
>> Hi Alex,
>>
>> your commit ("memory: jz4780-nemc: driver for the NEMC on JZ4780
>> SoCs") sets MACH_JZ4780 as Kconfig dependency for the JZ4780_NEMC
>> driver.
>>
>> +config JZ4780_NEMC
>> [...]
>> + depends on MACH_JZ4780
>>
>> MACH_JZ4780 is not defined in Kconfig, so that JZ4780_NEMC is always
>> false and the driver cannot be compiled.
>>
>> Is there a patch queued somewhere that adds the missing Kconfig option?
>>
>> I detected this issue with scripts/checkkconfigsymbols.py by diffing
>> yesterday's and today's linux-next tree.
>>
>> Kind regards,
>> Valentin
>>