Realtek RTL8822BE BT chip on ASUS X420FA cannot be turned on correctly
after on-off several times. Bluetooth daemon sets BT mode failed when
this issue happens.
bluetoothd[1576]: Failed to set mode: Failed (0x03)
If BT is tunred off, then turned on again, it works correctly again.
This patch makes RTL8822BE BT reset on close to fix this issue.
Signed-off-by: Jian-Hong Pan <[email protected]>
---
drivers/bluetooth/btrtl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 208feef63de4..7e9930f0f231 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -608,10 +608,11 @@ int btrtl_download_firmware(struct hci_dev *hdev,
case RTL_ROM_LMP_8723A:
case RTL_ROM_LMP_3499:
return btrtl_setup_rtl8723a(hdev, btrtl_dev);
+ case RTL_ROM_LMP_8822B:
+ set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);
case RTL_ROM_LMP_8723B:
case RTL_ROM_LMP_8821A:
case RTL_ROM_LMP_8761A:
- case RTL_ROM_LMP_8822B:
return btrtl_setup_rtl8723b(hdev, btrtl_dev);
default:
rtl_dev_info(hdev, "rtl: assuming no firmware upload needed\n");
--
2.20.1
Hi Jian-Hong,
On Fri, Jun 21, 2019 at 4:59 PM Jian-Hong Pan <[email protected]> wrote:
> Realtek RTL8822BE BT chip on ASUS X420FA cannot be turned on correctly
> after on-off several times. Bluetooth daemon sets BT mode failed when
> this issue happens.
>
> bluetoothd[1576]: Failed to set mode: Failed (0x03)
>
> If BT is tunred off, then turned on again, it works correctly again.
> This patch makes RTL8822BE BT reset on close to fix this issue.
I know we've been trying to understand why Realtek's own bluetooth
driver avoids this bug, but is this solution based upon code in the
vendor driver?
At a glance I can't see the flag (or equivalent) being set there.
Daniel
Realtek RTL8822BE BT chip on ASUS X420FA cannot be turned on correctly
after on-off several times. Bluetooth daemon sets BT mode failed when
this issue happens.
bluetoothd[1576]: Failed to set mode: Failed (0x03)
If BT is tunred off, then turned on again, it works correctly again.
According to the vendor driver, the HCI_QUIRK_RESET_ON_CLOSE flag is set
during probing. So, this patch makes Realtek's BT reset on close to fix
this issue.
Signed-off-by: Jian-Hong Pan <[email protected]>
---
v2:
- According to the vendor driver, it makes "all" Realtek's BT reset on
close. So, this version makes it the same.
- Change to the new subject for all Realtek BT chips.
drivers/bluetooth/btrtl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 208feef63de4..be6d5f7e1e44 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -630,6 +630,10 @@ int btrtl_setup_realtek(struct hci_dev *hdev)
return PTR_ERR(btrtl_dev);
ret = btrtl_download_firmware(hdev, btrtl_dev);
+ /* According to the vendor driver, BT must be reset on close to avoid
+ * firmware crash since kernel v3.7.1.
+ */
+ set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);
btrtl_free(btrtl_dev);
--
2.22.0
On Mon, Jun 24, 2019 at 2:24 PM Jian-Hong Pan <[email protected]> wrote:
> Realtek RTL8822BE BT chip on ASUS X420FA cannot be turned on correctly
> after on-off several times. Bluetooth daemon sets BT mode failed when
> this issue happens.
You could also mention that scanning must be active while turning off
for this bug to be hit.
> bluetoothd[1576]: Failed to set mode: Failed (0x03)
>
> If BT is tunred off, then turned on again, it works correctly again.
Typo: turned
> According to the vendor driver, the HCI_QUIRK_RESET_ON_CLOSE flag is set
> during probing. So, this patch makes Realtek's BT reset on close to fix
> this issue.
Checked the vendor driver - I see what you are referring to, so the
change seems correct.
#if HCI_VERSION_CODE >= KERNEL_VERSION(3, 7, 1)
if (!reset)
set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);
RTKBT_DBG("set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);");
#endif
However I'm pretty sure this is not saying that kernel 3.7.0 did not
need the reset. I think it just means that the flag did not exist
before Linux-3.7.1, so they added the ifdef to add some level of
compatibility with older kernel versions. I think you can remove
"since kernel v3.7.1." from the comment.
After those changes you can add:
Link: https://bugzilla.kernel.org/show_bug.cgi?id=203429
Reviewed-by: Daniel Drake <[email protected]>
> Signed-off-by: Jian-Hong Pan <[email protected]>
> ---
> v2:
> - According to the vendor driver, it makes "all" Realtek's BT reset on
> close. So, this version makes it the same.
> - Change to the new subject for all Realtek BT chips.
>
> drivers/bluetooth/btrtl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 208feef63de4..be6d5f7e1e44 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -630,6 +630,10 @@ int btrtl_setup_realtek(struct hci_dev *hdev)
> return PTR_ERR(btrtl_dev);
>
> ret = btrtl_download_firmware(hdev, btrtl_dev);
> + /* According to the vendor driver, BT must be reset on close to avoid
> + * firmware crash since kernel v3.7.1.
> + */
> + set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);
>
> btrtl_free(btrtl_dev);
>
> --
> 2.22.0
>
Hi Daniel,
>> Realtek RTL8822BE BT chip on ASUS X420FA cannot be turned on correctly
>> after on-off several times. Bluetooth daemon sets BT mode failed when
>> this issue happens.
>
> You could also mention that scanning must be active while turning off
> for this bug to be hit.
>
>> bluetoothd[1576]: Failed to set mode: Failed (0x03)
>>
>> If BT is tunred off, then turned on again, it works correctly again.
>
> Typo: turned
>
>> According to the vendor driver, the HCI_QUIRK_RESET_ON_CLOSE flag is set
>> during probing. So, this patch makes Realtek's BT reset on close to fix
>> this issue.
>
> Checked the vendor driver - I see what you are referring to, so the
> change seems correct.
>
> #if HCI_VERSION_CODE >= KERNEL_VERSION(3, 7, 1)
> if (!reset)
> set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);
> RTKBT_DBG("set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);");
> #endif
>
> However I'm pretty sure this is not saying that kernel 3.7.0 did not
> need the reset. I think it just means that the flag did not exist
> before Linux-3.7.1, so they added the ifdef to add some level of
> compatibility with older kernel versions. I think you can remove
> "since kernel v3.7.1." from the comment.
>
> After those changes you can add:
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203429
> Reviewed-by: Daniel Drake <[email protected]>
if someone wants to use HCI_Reset to ensure that all their connections and radio usage is reset, then they should do that via the hdev->shutdown handler. Look at btusb.c if you need an example.
This quirk is for hardware that can not use HCI_Reset on init which is Bluetooth 1.0b hardware.
Regards
Marcel