2020-04-15 21:59:19

by Ezequiel Garcia

Subject: [PATCH] hwspinlock: Simplify Kconfig

Every hwspinlock driver is expected to depend on the
hwspinlock core, so it's possible to simplify the
Kconfig, factoring out the HWSPINLOCK dependency.

Signed-off-by: Ezequiel Garcia <[email protected]>
---
drivers/hwspinlock/Kconfig | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
index 826a1054100d..32cd26352f38 100644
--- a/drivers/hwspinlock/Kconfig
+++ b/drivers/hwspinlock/Kconfig
@@ -6,9 +6,10 @@
menuconfig HWSPINLOCK
bool "Hardware Spinlock drivers"

+if HWSPINLOCK
+
config HWSPINLOCK_OMAP
tristate "OMAP Hardware Spinlock device"
- depends on HWSPINLOCK
depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
help
Say y here to support the OMAP Hardware Spinlock device (firstly
@@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP

config HWSPINLOCK_QCOM
tristate "Qualcomm Hardware Spinlock device"
- depends on HWSPINLOCK
depends on ARCH_QCOM || COMPILE_TEST
select MFD_SYSCON
help
@@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM

config HWSPINLOCK_SIRF
tristate "SIRF Hardware Spinlock device"
- depends on HWSPINLOCK
depends on ARCH_SIRF || COMPILE_TEST
help
Say y here to support the SIRF Hardware Spinlock device, which
@@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
config HWSPINLOCK_SPRD
tristate "SPRD Hardware Spinlock device"
depends on ARCH_SPRD || COMPILE_TEST
- depends on HWSPINLOCK
help
Say y here to support the SPRD Hardware Spinlock device.

@@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
config HWSPINLOCK_STM32
tristate "STM32 Hardware Spinlock device"
depends on MACH_STM32MP157 || COMPILE_TEST
- depends on HWSPINLOCK
help
Say y here to support the STM32 Hardware Spinlock device.

@@ -60,7 +57,6 @@ config HWSPINLOCK_STM32

config HSEM_U8500
tristate "STE Hardware Semaphore functionality"
- depends on HWSPINLOCK
depends on ARCH_U8500 || COMPILE_TEST
help
Say y here to support the STE Hardware Semaphore functionality, which
@@ -68,3 +64,5 @@ config HSEM_U8500
SoC.

If unsure, say N.
+
+endif # HWSPINLOCK
--
2.26.0.rc2

2020-04-16 00:07:44

by Baolin Wang

Subject: Re: [PATCH] hwspinlock: Simplify Kconfig

Hi Ezequiel,

On Wed, Apr 15, 2020 at 6:09 AM Ezequiel Garcia <[email protected]> wrote:
>
> Every hwspinlock driver is expected to depend on the
> hwspinlock core, so it's possible to simplify the
> Kconfig, factoring out the HWSPINLOCK dependency.
>
> Signed-off-by: Ezequiel Garcia <[email protected]>

Looks reasonable to me.
Reviewed-by: Baolin Wang <[email protected]>

> ---
> drivers/hwspinlock/Kconfig | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
> index 826a1054100d..32cd26352f38 100644
> --- a/drivers/hwspinlock/Kconfig
> +++ b/drivers/hwspinlock/Kconfig
> @@ -6,9 +6,10 @@
> menuconfig HWSPINLOCK
> bool "Hardware Spinlock drivers"
>
> +if HWSPINLOCK
> +
> config HWSPINLOCK_OMAP
> tristate "OMAP Hardware Spinlock device"
> - depends on HWSPINLOCK
> depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
> help
> Say y here to support the OMAP Hardware Spinlock device (firstly
> @@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP
>
> config HWSPINLOCK_QCOM
> tristate "Qualcomm Hardware Spinlock device"
> - depends on HWSPINLOCK
> depends on ARCH_QCOM || COMPILE_TEST
> select MFD_SYSCON
> help
> @@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM
>
> config HWSPINLOCK_SIRF
> tristate "SIRF Hardware Spinlock device"
> - depends on HWSPINLOCK
> depends on ARCH_SIRF || COMPILE_TEST
> help
> Say y here to support the SIRF Hardware Spinlock device, which
> @@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
> config HWSPINLOCK_SPRD
> tristate "SPRD Hardware Spinlock device"
> depends on ARCH_SPRD || COMPILE_TEST
> - depends on HWSPINLOCK
> help
> Say y here to support the SPRD Hardware Spinlock device.
>
> @@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
> config HWSPINLOCK_STM32
> tristate "STM32 Hardware Spinlock device"
> depends on MACH_STM32MP157 || COMPILE_TEST
> - depends on HWSPINLOCK
> help
> Say y here to support the STM32 Hardware Spinlock device.
>
> @@ -60,7 +57,6 @@ config HWSPINLOCK_STM32
>
> config HSEM_U8500
> tristate "STE Hardware Semaphore functionality"
> - depends on HWSPINLOCK
> depends on ARCH_U8500 || COMPILE_TEST
> help
> Say y here to support the STE Hardware Semaphore functionality, which
> @@ -68,3 +64,5 @@ config HSEM_U8500
> SoC.
>
> If unsure, say N.
> +
> +endif # HWSPINLOCK
> --
> 2.26.0.rc2
>


--
Baolin Wang

2020-05-07 03:26:26

by Ezequiel Garcia

Subject: Re: [PATCH] hwspinlock: Simplify Kconfig

Hello,

On Wed, 15 Apr 2020 at 10:33, Baolin Wang <[email protected]> wrote:
>
> Hi Ezequiel,
>
> On Wed, Apr 15, 2020 at 6:09 AM Ezequiel Garcia <[email protected]> wrote:
> >
> > Every hwspinlock driver is expected to depend on the
> > hwspinlock core, so it's possible to simplify the
> > Kconfig, factoring out the HWSPINLOCK dependency.
> >
> > Signed-off-by: Ezequiel Garcia <[email protected]>
>
> Looks reasonable to me.
> Reviewed-by: Baolin Wang <[email protected]>
>

Gentle ping.

Thanks!
Ezequiel

> > ---
> > drivers/hwspinlock/Kconfig | 10 ++++------
> > 1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
> > index 826a1054100d..32cd26352f38 100644
> > --- a/drivers/hwspinlock/Kconfig
> > +++ b/drivers/hwspinlock/Kconfig
> > @@ -6,9 +6,10 @@
> > menuconfig HWSPINLOCK
> > bool "Hardware Spinlock drivers"
> >
> > +if HWSPINLOCK
> > +
> > config HWSPINLOCK_OMAP
> > tristate "OMAP Hardware Spinlock device"
> > - depends on HWSPINLOCK
> > depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
> > help
> > Say y here to support the OMAP Hardware Spinlock device (firstly
> > @@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP
> >
> > config HWSPINLOCK_QCOM
> > tristate "Qualcomm Hardware Spinlock device"
> > - depends on HWSPINLOCK
> > depends on ARCH_QCOM || COMPILE_TEST
> > select MFD_SYSCON
> > help
> > @@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM
> >
> > config HWSPINLOCK_SIRF
> > tristate "SIRF Hardware Spinlock device"
> > - depends on HWSPINLOCK
> > depends on ARCH_SIRF || COMPILE_TEST
> > help
> > Say y here to support the SIRF Hardware Spinlock device, which
> > @@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
> > config HWSPINLOCK_SPRD
> > tristate "SPRD Hardware Spinlock device"
> > depends on ARCH_SPRD || COMPILE_TEST
> > - depends on HWSPINLOCK
> > help
> > Say y here to support the SPRD Hardware Spinlock device.
> >
> > @@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
> > config HWSPINLOCK_STM32
> > tristate "STM32 Hardware Spinlock device"
> > depends on MACH_STM32MP157 || COMPILE_TEST
> > - depends on HWSPINLOCK
> > help
> > Say y here to support the STM32 Hardware Spinlock device.
> >
> > @@ -60,7 +57,6 @@ config HWSPINLOCK_STM32
> >
> > config HSEM_U8500
> > tristate "STE Hardware Semaphore functionality"
> > - depends on HWSPINLOCK
> > depends on ARCH_U8500 || COMPILE_TEST
> > help
> > Say y here to support the STE Hardware Semaphore functionality, which
> > @@ -68,3 +64,5 @@ config HSEM_U8500
> > SoC.
> >
> > If unsure, say N.
> > +
> > +endif # HWSPINLOCK
> > --
> > 2.26.0.rc2
> >
>
>
> --
> Baolin Wang

2020-05-12 23:30:38

by Bjorn Andersson

Subject: Re: [PATCH] hwspinlock: Simplify Kconfig

On Wed 06 May 19:39 PDT 2020, Ezequiel Garcia wrote:

> Hello,
>
> On Wed, 15 Apr 2020 at 10:33, Baolin Wang <[email protected]> wrote:
> >
> > Hi Ezequiel,
> >
> > On Wed, Apr 15, 2020 at 6:09 AM Ezequiel Garcia <[email protected]> wrote:
> > >
> > > Every hwspinlock driver is expected to depend on the
> > > hwspinlock core, so it's possible to simplify the
> > > Kconfig, factoring out the HWSPINLOCK dependency.
> > >
> > > Signed-off-by: Ezequiel Garcia <[email protected]>
> >
> > Looks reasonable to me.
> > Reviewed-by: Baolin Wang <[email protected]>
> >
>
> Gentle ping.
>

Applied.

Thanks,
Bjorn

> Thanks!
> Ezequiel
>
> > > ---
> > > drivers/hwspinlock/Kconfig | 10 ++++------
> > > 1 file changed, 4 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
> > > index 826a1054100d..32cd26352f38 100644
> > > --- a/drivers/hwspinlock/Kconfig
> > > +++ b/drivers/hwspinlock/Kconfig
> > > @@ -6,9 +6,10 @@
> > > menuconfig HWSPINLOCK
> > > bool "Hardware Spinlock drivers"
> > >
> > > +if HWSPINLOCK
> > > +
> > > config HWSPINLOCK_OMAP
> > > tristate "OMAP Hardware Spinlock device"
> > > - depends on HWSPINLOCK
> > > depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
> > > help
> > > Say y here to support the OMAP Hardware Spinlock device (firstly
> > > @@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP
> > >
> > > config HWSPINLOCK_QCOM
> > > tristate "Qualcomm Hardware Spinlock device"
> > > - depends on HWSPINLOCK
> > > depends on ARCH_QCOM || COMPILE_TEST
> > > select MFD_SYSCON
> > > help
> > > @@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM
> > >
> > > config HWSPINLOCK_SIRF
> > > tristate "SIRF Hardware Spinlock device"
> > > - depends on HWSPINLOCK
> > > depends on ARCH_SIRF || COMPILE_TEST
> > > help
> > > Say y here to support the SIRF Hardware Spinlock device, which
> > > @@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
> > > config HWSPINLOCK_SPRD
> > > tristate "SPRD Hardware Spinlock device"
> > > depends on ARCH_SPRD || COMPILE_TEST
> > > - depends on HWSPINLOCK
> > > help
> > > Say y here to support the SPRD Hardware Spinlock device.
> > >
> > > @@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
> > > config HWSPINLOCK_STM32
> > > tristate "STM32 Hardware Spinlock device"
> > > depends on MACH_STM32MP157 || COMPILE_TEST
> > > - depends on HWSPINLOCK
> > > help
> > > Say y here to support the STM32 Hardware Spinlock device.
> > >
> > > @@ -60,7 +57,6 @@ config HWSPINLOCK_STM32
> > >
> > > config HSEM_U8500
> > > tristate "STE Hardware Semaphore functionality"
> > > - depends on HWSPINLOCK
> > > depends on ARCH_U8500 || COMPILE_TEST
> > > help
> > > Say y here to support the STE Hardware Semaphore functionality, which
> > > @@ -68,3 +64,5 @@ config HSEM_U8500
> > > SoC.
> > >
> > > If unsure, say N.
> > > +
> > > +endif # HWSPINLOCK
> > > --
> > > 2.26.0.rc2
> > >
> >
> >
> > --
> > Baolin Wang