2015-04-01 23:00:32

by Mel Gorman

[permalink] [raw]
Subject: Re: [PATCH] Do not use arbitrary large movablecore to calculate kernelcore

On Sat, Mar 28, 2015 at 11:36:02PM -0400, Zhihui Zhang wrote:
> If kernelcore is not set, then we are working with a very large kernelcore
> for nothing - no movable zone will be created. If kernelcore is set,
> then it is not respected at all.
>
> Signed-off-by: Zhihui Zhang <[email protected]>

I'm confused. What bug is this patch fixing? What is the user-visible
impcat of the patch?


2015-04-03 01:21:56

by Zhihui Zhang

[permalink] [raw]
Subject: Re: [PATCH] Do not use arbitrary large movablecore to calculate kernelcore

If you specify movablecore > totalpages, required_kernelcore will end
up with a big number because corepages is an unsigned integer. If so,
the following nested is a waste of time. But I see your point.

-Zhihui

On Wed, Apr 1, 2015 at 7:00 PM, Mel Gorman <[email protected]> wrote:
> On Sat, Mar 28, 2015 at 11:36:02PM -0400, Zhihui Zhang wrote:
>> If kernelcore is not set, then we are working with a very large kernelcore
>> for nothing - no movable zone will be created. If kernelcore is set,
>> then it is not respected at all.
>>
>> Signed-off-by: Zhihui Zhang <[email protected]>
>
> I'm confused. What bug is this patch fixing? What is the user-visible
> impcat of the patch?