2019-05-24 04:30:45

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the cifs tree

Hi all,

In commit

f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")

Fixes tag

Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")

has these problem(s):

- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-05-24 14:16:33

by Steve French

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the cifs tree

fixed and repushed to cifs-2.6.git for-next

On Thu, May 23, 2019 at 11:27 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commit
>
> f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")
>
> Fixes tag
>
> Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>
> --
> Cheers,
> Stephen Rothwell



--
Thanks,

Steve

2019-05-29 03:26:31

by Murphy Zhou

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the cifs tree

On Fri, May 24, 2019 at 10:14 PM Steve French <[email protected]> wrote:
>
> fixed and repushed to cifs-2.6.git for-next

Thanks!

[resend including mail lists]

>
> On Thu, May 23, 2019 at 11:27 PM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> > f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")
> >
> > Fixes tag
> >
> > Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")
> >
> > has these problem(s):
> >
> > - SHA1 should be at least 12 digits long
> > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > or later) just making sure it is not set (or set to "auto").
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
>
> --
> Thanks,
>
> Steve