2023-08-30 22:11:15

by Sudip Mukherjee

[permalink] [raw]
Subject: mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

Hi All,

The latest mainline kernel branch fails to build alpha, csky and s390
allmodconfig with the error:

drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function]
1138 | static int cs42l43_runtime_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function]
1124 | static int cs42l43_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function]
1106 | static int cs42l43_resume(struct device *dev)
| ^~~~~~~~~~~~~~
drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function]
1076 | static int cs42l43_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~

git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

I will be happy to test any patch or provide any extra log if needed.


--
Regards
Sudip


2023-09-24 03:58:58

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

Hi All,

On Wed, 30 Aug 2023 at 12:29, Sudip Mukherjee (Codethink)
<[email protected]> wrote:
>
> Hi All,
>
> The latest mainline kernel branch fails to build alpha, csky and s390
> allmodconfig with the error:
>
> drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function]
> 1138 | static int cs42l43_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function]
> 1124 | static int cs42l43_runtime_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function]
> 1106 | static int cs42l43_resume(struct device *dev)
> | ^~~~~~~~~~~~~~
> drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function]
> 1076 | static int cs42l43_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~
>
> git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

Since its almost time for v6.6-rc3, so just a quick reminder that this
build failure is still not fixed.


--
Regards
Sudip

Subject: Re: mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

On 23.09.23 17:02, Sudip Mukherjee wrote:
> On Wed, 30 Aug 2023 at 12:29, Sudip Mukherjee (Codethink)
> <[email protected]> wrote:
>>
>> Hi All,
>>
>> The latest mainline kernel branch fails to build alpha, csky and s390
>> allmodconfig with the error:
>>
>> drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function]
>> 1138 | static int cs42l43_runtime_resume(struct device *dev)
>> | ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function]
>> 1124 | static int cs42l43_runtime_suspend(struct device *dev)
>> | ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function]
>> 1106 | static int cs42l43_resume(struct device *dev)
>> | ^~~~~~~~~~~~~~
>> drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function]
>> 1076 | static int cs42l43_suspend(struct device *dev)
>> | ^~~~~~~~~~~~~~~
>>
>> git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
>
> Since its almost time for v6.6-rc3, so just a quick reminder that this
> build failure is still not fixed.

Are you sure? I had expected eb72d5207008db ("mfd: cs42l43: Use correct
macro for new-style PM runtime ops")[1] that was merged this week would
have fixed this. Or am I mixing different problems up here?

Ciao, Thorsten

[1]
https://lore.kernel.org/all/[email protected]/

Subject: Re: mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

On 24.09.23 09:58, Thorsten Leemhuis wrote:
> On 23.09.23 17:02, Sudip Mukherjee wrote:
>> On Wed, 30 Aug 2023 at 12:29, Sudip Mukherjee (Codethink)
>> <[email protected]> wrote:
>>>
>>> The latest mainline kernel branch fails to build alpha, csky and s390
>>> allmodconfig with the error:
>>>
>>> drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function]
>>> 1138 | static int cs42l43_runtime_resume(struct device *dev)
>>> | ^~~~~~~~~~~~~~~~~~~~~~
>>> drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function]
>>> 1124 | static int cs42l43_runtime_suspend(struct device *dev)
>>> | ^~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function]
>>> 1106 | static int cs42l43_resume(struct device *dev)
>>> | ^~~~~~~~~~~~~~
>>> drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function]
>>> 1076 | static int cs42l43_suspend(struct device *dev)
>>> | ^~~~~~~~~~~~~~~
>>>
>>> git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
>>
>> Since its almost time for v6.6-rc3, so just a quick reminder that this
>> build failure is still not fixed.
>
> Are you sure? I had expected eb72d5207008db ("mfd: cs42l43: Use correct
> macro for new-style PM runtime ops")[1] that was merged this week would
> have fixed this. Or am I mixing different problems up here?

Ahh, sorry, just noticed Linus merged that fix a few hours after your
mail, so I guess everything should be settled now. Ciao, Thorsten