When building tinyconfig on parisc the following error shows up:
/tmp/kernel/signal.c: In function 'do_sigaction':
/tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?
#define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
^~~~~~~~~~~~~
The changes in the two individual patches listed in 'Fixes' below are
OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be
supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific
fcntl and signal flags").
Fixes: 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
Fixes: 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
Signed-off-by: Anders Roxell <[email protected]>
---
arch/parisc/include/asm/signal.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/parisc/include/asm/signal.h b/arch/parisc/include/asm/signal.h
index 30dd1e43ef88..715c96ba2ec8 100644
--- a/arch/parisc/include/asm/signal.h
+++ b/arch/parisc/include/asm/signal.h
@@ -21,8 +21,6 @@ typedef struct {
unsigned long sig[_NSIG_WORDS];
} sigset_t;
-#define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
-
#include <asm/sigcontext.h>
#endif /* !__ASSEMBLY */
--
2.29.2
On 11/26/20 2:06 PM, Anders Roxell wrote:
> When building tinyconfig on parisc the following error shows up:
>
> /tmp/kernel/signal.c: In function 'do_sigaction':
> /tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?
> #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> ^~~~~~~~~~~~~
>
> The changes in the two individual patches listed in 'Fixes' below are
> OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be
> supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific
> fcntl and signal flags").
>
> Fixes: 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
> Fixes: 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
> Signed-off-by: Anders Roxell <[email protected]>
> ---
> arch/parisc/include/asm/signal.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/parisc/include/asm/signal.h b/arch/parisc/include/asm/signal.h
> index 30dd1e43ef88..715c96ba2ec8 100644
> --- a/arch/parisc/include/asm/signal.h
> +++ b/arch/parisc/include/asm/signal.h
> @@ -21,8 +21,6 @@ typedef struct {
> unsigned long sig[_NSIG_WORDS];
> } sigset_t;
>
> -#define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> -
Which kernel are you testing?
I don't see this line in current git head...?!?
Helge
> #include <asm/sigcontext.h>
>
> #endif /* !__ASSEMBLY */
>
On Thu, 26 Nov 2020 at 15:46, Helge Deller <[email protected]> wrote:
>
> On 11/26/20 2:06 PM, Anders Roxell wrote:
> > When building tinyconfig on parisc the following error shows up:
> >
> > /tmp/kernel/signal.c: In function 'do_sigaction':
> > /tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?
> > #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> > ^~~~~~~~~~~~~
> >
> > The changes in the two individual patches listed in 'Fixes' below are
> > OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be
> > supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific
> > fcntl and signal flags").
> >
> > Fixes: 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
> > Fixes: 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
> > Signed-off-by: Anders Roxell <[email protected]>
> > ---
> > arch/parisc/include/asm/signal.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/parisc/include/asm/signal.h b/arch/parisc/include/asm/signal.h
> > index 30dd1e43ef88..715c96ba2ec8 100644
> > --- a/arch/parisc/include/asm/signal.h
> > +++ b/arch/parisc/include/asm/signal.h
> > @@ -21,8 +21,6 @@ typedef struct {
> > unsigned long sig[_NSIG_WORDS];
> > } sigset_t;
> >
> > -#define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> > -
>
> Which kernel are you testing?
I used used linux-next tag: next-20201126
Cheers,
Anders
> I don't see this line in current git head...?!?
>
> Helge
>
> > #include <asm/sigcontext.h>
> >
> > #endif /* !__ASSEMBLY */
> >
>
Anders,
On Fri, 27 Nov 2020 at 04:10, Anders Roxell <[email protected]> wrote:
>
> On Thu, 26 Nov 2020 at 15:46, Helge Deller <[email protected]> wrote:
> >
> > On 11/26/20 2:06 PM, Anders Roxell wrote:
> > > When building tinyconfig on parisc the following error shows up:
> > >
> > > /tmp/kernel/signal.c: In function 'do_sigaction':
> > > /tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?
> > > #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> > > ^~~~~~~~~~~~~
> > >
> > > The changes in the two individual patches listed in 'Fixes' below are
> > > OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be
> > > supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific
> > > fcntl and signal flags").
> > >
> > > Fixes: 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
> > > Fixes: 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
> > > Signed-off-by: Anders Roxell <[email protected]>
Thanks for your patch the builds are successful now.
Fixes (compared to build next-20201130)
------------------------------------------------------------------------
parisc:
build:
* gcc-10-allnoconfig
* gcc-10-defconfig
* gcc-10-tinyconfig
* gcc-8-allnoconfig
* gcc-8-defconfig
* gcc-8-tinyconfig
* gcc-9-allnoconfig
* gcc-9-defconfig
* gcc-9-tinyconfig
- Naresh
Anders,
On Wed, 2 Dec 2020 at 13:31, Naresh Kamboju <[email protected]> wrote:
>
> Anders,
>
> On Fri, 27 Nov 2020 at 04:10, Anders Roxell <[email protected]> wrote:
> >
> > On Thu, 26 Nov 2020 at 15:46, Helge Deller <[email protected]> wrote:
> > >
> > > On 11/26/20 2:06 PM, Anders Roxell wrote:
> > > > When building tinyconfig on parisc the following error shows up:
> > > >
> > > > /tmp/kernel/signal.c: In function 'do_sigaction':
> > > > /tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?
> > > > #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> > > > ^~~~~~~~~~~~~
I see these build failures on Linux mainline.
ref:
https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline/-/jobs/911416687
Steps to reproduce:
-----------------------------
# TuxMake is a command line tool and Python library that provides
# portable and repeatable Linux kernel builds across a variety of
# architectures, toolchains, kernel configurations, and make targets.
#
# TuxMake supports the concept of runtimes.
# See https://docs.tuxmake.org/runtimes/, for that to work it requires
# that you install podman or docker on your system.
#
# To install tuxmake on your system globally:
# sudo pip3 install -U tuxmake
#
# See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime docker --target-arch parisc --toolchain gcc-9
--kconfig defconfig
- Naresh