On 26/12/2023 03:37, xiazhengqiao wrote:
> Because ilitek, ili2901 needs to use reset to pull down the time for 10ms,
> so we need to control the reset, use this drive control.
I don't see relation between commit msg and the patch itself. Perhaps
you wanted to say you document new device which is different than elan one?
Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch` helps here to create proper versioned patches.
Another useful tool is b4. Skipping the PATCH keyword makes filtering of
emails more difficult thus making the review process less convenient.
A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
>
> Signed-off-by: xiazhengqiao <[email protected]>
Your name still does not look like in other reply.
> ---
> Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
What supplies does the device have? Not the driver, the device as
written in datasheet?
Best regards,
Krzysztof
Hi Krzysztof，
Thanks for your patient reply.
On Tue, Dec 26, 2023 at 5:09 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 26/12/2023 03:37, xiazhengqiao wrote:
> > Because ilitek, ili2901 needs to use reset to pull down the time for 10ms,
> > so we need to control the reset, use this drive control.
>
> I don't see relation between commit msg and the patch itself. Perhaps
> you wanted to say you document new device which is different than elan one?
>
Yes, I added a new touch, its timing is a little different from "elan,
ekth6915", and other control logic is similar.
I will re-commit my message.
>
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch` helps here to create proper versioned patches.
> Another useful tool is b4. Skipping the PATCH keyword makes filtering of
> emails more difficult thus making the review process less convenient.
>
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
>
Thanks for your guidance, I will modify it.
> >
> > Signed-off-by: xiazhengqiao <[email protected]>
>
> Your name still does not look like in other reply.
Do you mean there is something wrong with my name? How about changing
it to the following:
Signed-off-by: Zhengqiao Xia <[email protected]>
>
> > ---
> > Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
>
> What supplies does the device have? Not the driver, the device as
> written in datasheet?
This device only has a 3.3V power supply, I call it "vcc33".
>
> Best regards,
> Krzysztof
>
Best regards,
Zhengqiao