2020-04-16 00:12:51

by Nicolas Saenz Julienne

[permalink] [raw]
Subject: [PATCH] ARM: dts: bcm283x: Disable dsi0 node

Since its inception the module was meant to be disabled by default, but
the original commit failed to add the relevant property.

Fixes: 4aba4cf82054 ("ARM: dts: bcm2835: Add the DSI module nodes and clocks")
Signed-off-by: Nicolas Saenz Julienne <[email protected]>
---
arch/arm/boot/dts/bcm283x.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index e1abe8c730cef..b83a864e2e8ba 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -372,6 +372,7 @@ dsi0: dsi@7e209000 {
"dsi0_ddr2",
"dsi0_ddr";

+ status = "disabled";
};

aux: aux@7e215000 {
--
2.26.0


2020-04-16 01:02:25

by Eric Anholt

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: bcm283x: Disable dsi0 node

On Wed, Apr 15, 2020 at 7:42 AM Nicolas Saenz Julienne
<[email protected]> wrote:
>
> Since its inception the module was meant to be disabled by default, but
> the original commit failed to add the relevant property.
>
> Fixes: 4aba4cf82054 ("ARM: dts: bcm2835: Add the DSI module nodes and clocks")
> Signed-off-by: Nicolas Saenz Julienne <[email protected]>
> ---
> arch/arm/boot/dts/bcm283x.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> index e1abe8c730cef..b83a864e2e8ba 100644
> --- a/arch/arm/boot/dts/bcm283x.dtsi
> +++ b/arch/arm/boot/dts/bcm283x.dtsi
> @@ -372,6 +372,7 @@ dsi0: dsi@7e209000 {
> "dsi0_ddr2",
> "dsi0_ddr";
>
> + status = "disabled";
> };

If you've confirmed that vc4 still probes,

Reviewed-by: Eric Anholt <[email protected]>

2020-04-16 09:38:57

by Nicolas Saenz Julienne

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: bcm283x: Disable dsi0 node

On Wed, 2020-04-15 at 12:17 -0700, Eric Anholt wrote:
> On Wed, Apr 15, 2020 at 7:42 AM Nicolas Saenz Julienne
> <[email protected]> wrote:
> > Since its inception the module was meant to be disabled by default, but
> > the original commit failed to add the relevant property.
> >
> > Fixes: 4aba4cf82054 ("ARM: dts: bcm2835: Add the DSI module nodes and
> > clocks")
> > Signed-off-by: Nicolas Saenz Julienne <[email protected]>
> > ---
> > arch/arm/boot/dts/bcm283x.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> > index e1abe8c730cef..b83a864e2e8ba 100644
> > --- a/arch/arm/boot/dts/bcm283x.dtsi
> > +++ b/arch/arm/boot/dts/bcm283x.dtsi
> > @@ -372,6 +372,7 @@ dsi0: dsi@7e209000 {
> > "dsi0_ddr2",
> > "dsi0_ddr";
> >
> > + status = "disabled";
> > };
>
> If you've confirmed that vc4 still probes,

Confirmed.

> Reviewed-by: Eric Anholt <[email protected]>

Thanks,
Nicolas

Attachments:
signature.asc (499.00 B)
This is a digitally signed message part

2020-04-16 21:01:16

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: bcm283x: Disable dsi0 node

On Wed, 15 Apr 2020 16:42:33 +0200, Nicolas Saenz Julienne <[email protected]> wrote:
> Since its inception the module was meant to be disabled by default, but
> the original commit failed to add the relevant property.
>
> Fixes: 4aba4cf82054 ("ARM: dts: bcm2835: Add the DSI module nodes and clocks")
> Signed-off-by: Nicolas Saenz Julienne <[email protected]>
> ---

Applied to devicetree/fixes, thanks!
--
Florian