2022-05-09 03:18:29

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH] drm/amdkfd: Return true/false (not 1/0) from bool functions

On Thu, May 5, 2022 at 10:05 PM Haowen Bai <[email protected]> wrote:
>
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> functions.
>
> Signed-off-by: Haowen Bai <[email protected]>

Thanks, I just applied the same fix from someone else.

Alex

> ---
> drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> index c3919aaa76e6..1431f0961769 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> @@ -241,14 +241,14 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
> if (/*!KFD_IRQ_IS_FENCE(client_id, source_id) &&*/
> (vmid < dev->vm_info.first_vmid_kfd ||
> vmid > dev->vm_info.last_vmid_kfd))
> - return 0;
> + return false;
>
> pasid = SOC15_PASID_FROM_IH_ENTRY(ih_ring_entry);
> context_id0 = SOC15_CONTEXT_ID0_FROM_IH_ENTRY(ih_ring_entry);
>
> if ((source_id == SOC15_INTSRC_CP_END_OF_PIPE) &&
> (context_id0 & AMDGPU_FENCE_MES_QUEUE_FLAG))
> - return 0;
> + return false;
>
> pr_debug("client id 0x%x, source id %d, vmid %d, pasid 0x%x. raw data:\n",
> client_id, source_id, vmid, pasid);
> @@ -258,7 +258,7 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
>
> /* If there is no valid PASID, it's likely a bug */
> if (WARN_ONCE(pasid == 0, "Bug: No PASID in KFD interrupt"))
> - return 0;
> + return false;
>
> /* Interrupt types we care about: various signals and faults.
> * They will be forwarded to a work queue (see below).
> --
> 2.7.4
>